Enforce corporate_id claim in Penpot auth_request middleware#36
Open
UsamaSadiq wants to merge 1 commit into
Open
Enforce corporate_id claim in Penpot auth_request middleware#36UsamaSadiq wants to merge 1 commit into
UsamaSadiq wants to merge 1 commit into
Conversation
Signed-off-by: Usama Sadiq <usama.sadiq@arbisoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add corporate_id enforcement to Penpot's
wrap-authzmiddleware inauth_request.clj. WhenPENPOT_SMB_CORPORATE_IDis set, the middleware decodes theX-Auth-Request-Access-TokenJWT payload and rejects requests wherecustom:is_corporateis not"true"orcustom:corporate_iddoes not match the configured value. Returns 403 on mismatch. When the env var is empty or unset, all checks are skipped (backward compatible).This is the per-app Layer 2 enforcement that closes the Bearer token bypass path (
SKIP_JWT_BEARER_TOKENS=truein oauth2-proxy). Layer 1 enforcement in mpass-auth-proxy is already on foss-sandbox.