Potential fix for code scanning alert no. 3: Workflow does not contain permissions#2320
Open
andyleejordan wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 3: Workflow does not contain permissions#2320andyleejordan wants to merge 1 commit into
andyleejordan wants to merge 1 commit into
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses code scanning alert #3 ("Workflow does not contain permissions") by adding an explicit least-privilege permissions block to the emacs-test.yml GitHub Actions workflow. By default, GITHUB_TOKEN is granted broad permissions; scoping it to contents: read follows the principle of least privilege without changing the workflow's behavior, since all steps (checkout, build, run Emacs tests) only read repository contents.
Changes:
- Added a root-level
permissions:block withcontents: readbetween theontriggers and thejobsdefinition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/PowerShell/PowerShellEditorServices/security/code-scanning/3
Add an explicit
permissionsblock to the workflow soGITHUB_TOKENis least-privileged by default.Best fix here (without changing functionality): add at workflow root (after
onand beforejobs) a minimal permission set:contents: readThis applies to all jobs unless overridden and is sufficient for this workflow’s current steps (not creating releases, commenting on PRs, or pushing commits).
File to edit:
.github/workflows/emacs-test.ymljobs:).No imports, methods, or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.