add: runtime values through CPC_CTX - #9
Merged
Merged
Conversation
Problem ------- Currently both the parsers and values are defined statically. The parsers do need this but the values don't. This hurts reusability, for example when trying to use CPC_TAKE_QUOTED with different quote or escape characters. Solution -------- Allow defining runtime values by reusing the `CpcArena` user field. This way runtime value can be specified by: CPC_TAKE_QUOTED(p_span_ctx_bsquoted, CPC_CTX(QuotedCtx, quote), CPC_CTX(QuotedCtx, escape))
steve-chavez
changed the title
steve-chavez
marked this pull request as ready for review
July 19, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently both the parsers and values are defined statically. The parsers do need this but the values don't.
This hurts reusability, for example when trying to use CPC_TAKE_QUOTED with different quote or escape characters.
Solution
Allow defining runtime values by reusing the
CpcArenauser field.This way runtime value can be specified by: