add: make CPC_PARSE a variadic macro dispatch - #8
Merged
Merged
Conversation
Problem ------- The parser signature might change add parameters, this can cause breaking changes at call sites. Solution -------- Make the CPC_PARSE a variadic macro so it can be used to shield against breaking changes. If the parsers signature change, it will keep working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The parser signature might change and add parameters, this can cause breaking changes at call sites.
Solution
Make the CPC_PARSE a variadic macro so it can be used to shield against breaking changes. If the parsers signature change, it will keep working.