add: CpcErr struct to separate internal errors - #6
Merged
Conversation
Problem ------- It's unwieldy to have to look for a string to differentiate internal error messages. Right now we have to check for `arena surpassed` and `no progress`, but these are not regular parse errors. Solution -------- Change CpcResult to have a `CpcErr` field insted of a simple `const char* err`, this lets differentiate between internal errors and regular parse errors. This is a BREAKING CHANGE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's unwieldy to have to look for a string to differentiate internal error messages. Right now we have to check for
arena surpassedandno progress, but these are not regular parse errors.Solution
Change CpcResult to have a
CpcErrfield insted of a simpleconst char* err, this lets differentiate between internal errors and regular parse errors.This is a BREAKING CHANGE.