fix: contain inline Mermaid "fit to frame" to the frame height (no vertical scroll)#24
Merged
Merged
Conversation
…rtical scroll) Inline "fit to frame" scaled the diagram to the frame width only while the frame height stayed at the diagram's 100% height, so the frame and content heights did not match: a tall diagram (e.g. a long sequenceDiagram) overflowed the 70vh frame and showed a vertical scroll, and a wide one had dead space. Fit now contains the diagram within both the frame width and the 70vh height cap and sizes the frame to that fitted height, so frame and content match. Also compensate for Obsidian's app-wide `box-sizing: border-box`, whose 1px viewport border had eaten into the content box and left a faint 1-2px vertical scroll that only reproduced under border-box (not in a content-box harness). Adds a diagram-fit E2E regression test under a border-box harness and bumps to 1.1.7 (manifest/versions/CHANGELOG). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inline fit to frame scaled the diagram to the frame width only while the frame height stayed at the diagram's 100% height — so frame and content heights didn't match:
sequenceDiagram) overflowed the 70vh frame and showed a vertical scrollFix
box-sizing: border-box: the viewport's 1px border had eaten into the content box, leaving a faint 1–2px vertical scroll that only reproduced under border-box (not in acontent-boxharness).Tests
diagram-fit.test.mjsE2E (under a border-box harness so it exercises the real Obsidian box model) — verifies fit has no vertical scroll for wide+tall and tall+narrow shapes, and that the default view stays 100%.Bumps to 1.1.7 (manifest / versions / CHANGELOG) — release cuts automatically on merge to
main.🤖 Generated with Claude Code