Skip to content

Fixed the missing plots after handling multi-antenna logs.#418

Merged
bhers4 merged 2 commits into
masterfrom
fix-p1display-missing-plots
Jul 23, 2026
Merged

Fixed the missing plots after handling multi-antenna logs.#418
bhers4 merged 2 commits into
masterfrom
fix-p1display-missing-plots

Conversation

@bhers4

@bhers4 bhers4 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixes

  • After handling multi-antenna cases we were missing several plots since they were looking at the wrong source_id.

@bhers4
bhers4 requested a review from adamshapiro0 July 22, 2026 19:37
@bhers4 bhers4 self-assigned this Jul 22, 2026
Copilot AI review requested due to automatic review settings July 22, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing analysis plots in multi-antenna (multi-source_id) logs by ensuring GNSS plots are generated from the correct GNSS antenna source IDs, and by making the map plotting logic tolerant of some source IDs lacking pose data.

Changes:

  • Update map plotting to iterate all self.source_ids, skipping per-source empty/invalid pose data instead of aborting the entire map.
  • Update GNSS azimuth/elevation plotting to run per GNSS antenna source ID (matching existing multi-antenna behavior in other GNSS plots).
  • Adjust GNSS azimuth/elevation output naming and titles to include antenna labels and avoid filename collisions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/fusion_engine_client/analysis/analyzer.py

@adamshapiro0 adamshapiro0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except separate out pose IDs, and consider pre-computing and caching lists of IDs vs current _get_gnss_antenna_source_ids() func that regenerates the list on each call

Copilot AI review requested due to automatic review settings July 23, 2026 16:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

python/fusion_engine_client/analysis/analyzer.py:1096

  • visible is based on min(pose_source_ids), but pose_source_ids is only range-filtered (0-99) and may still include IDs that have no PoseMessage (or no valid solutions). If the smallest ID gets skipped in the loop (no pose / no valid), every remaining pose trace will be created with visible='legendonly', producing an empty-looking map by default even though valid pose data exists for a higher source_id.
            # Only put default source ID on map by default.
            legendgroup = None if len(pose_source_ids) == 1 else source_id
            visible = None if source_id == min(pose_source_ids) else 'legendonly'

@bhers4
bhers4 merged commit ef61ffe into master Jul 23, 2026
28 checks passed
@bhers4
bhers4 deleted the fix-p1display-missing-plots branch July 23, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants