Skip to content

Fixed clash in p1_display's plot_gnss_skyplot. - #415

Closed
thoshizaki wants to merge 1 commit into
masterfrom
fix-cn0
Closed

Fixed clash in p1_display's plot_gnss_skyplot.#415
thoshizaki wants to merge 1 commit into
masterfrom
fix-cn0

Conversation

@thoshizaki

Copy link
Copy Markdown
Contributor

Fixes

  • Conditioned for the cases idx is empty or not.
  • Let max_cn0_dbhz be always exactly len(p1_time) long and aligned to sv_data's epochs by timestamp, so the later decimation indexing at analyzer.py:1281 (max_cn0_dbhz[idx]) can no longer go out of bounds.
  • Forced satellite timestamps to be increasing (were not likely because this is a merged/"duo" log).

…ng. Let max_cn0_dbhz be always exactly len(p1_time) long and aligned to sv_data's epochs by timestamp so that the later decimation indexing at analyzer.py:1281 (max_cn0_dbhz[idx]) can no longer go out of bounds.
@thoshizaki thoshizaki self-assigned this Jul 21, 2026
@thoshizaki
thoshizaki requested a review from adamshapiro0 July 21, 2026 09:53
@thoshizaki thoshizaki added the bug Something isn't working label Jul 21, 2026
@thoshizaki thoshizaki changed the title Fixed clash in plot_gnss_skyplot. Fixed clash in p1_display's plot_gnss_skyplot. Jul 21, 2026
@thoshizaki

Copy link
Copy Markdown
Contributor Author

Comparison by 3 Logs

Left: master 2a8a893
(It gives error.)

Right: fix-cn0 a20fba3
(It does run.)

Amazon Leo (1) HITL Log

  • python p1_display.py aeb01 -p fix-cn0
image

Amazon Leo (2) HITL Log

  • python p1_display.py 7f32e -p fix-cn0
image

Atlas Duo, Test Drive

  • python p1_display.py dfa47f9 -p fix-cn0 --log-type user
image

@adamshapiro0

Copy link
Copy Markdown
Collaborator

Closing in favor of #416. The underlying issue here was that the GNSSSignals messages from the two antennas were conflicting and p1_display was not separating them, but instead trying to plot them together.

@adamshapiro0
adamshapiro0 deleted the fix-cn0 branch July 21, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants