fix(sonar): Batch 11 maintainability + coverage CI wiring - #41
Merged
Conversation
Satisfy go:S1186 on Upjet scaffold init stubs without AddToScheme; types register via SchemeBuilder / generated zz_*.go. Adds REQ-SONAR-PG-M01 meta test and OpenSpec sonar-maintainability-2026-08 scaffold + pg-m01.
Satisfy go:S1186 without AddToScheme (D-023). Meta test + OpenSpec PG-M01.
…-S19 Extract helpers so TestCRDGoldenContract, TestCRDStructuralInvariants, and FuzzGetExternalName stay ≤ Sonar S3776 threshold; replace anonymous nested crd view structs with named types (godre:S8205) without changing goldens.
Automatic Analysis cannot import Go coverprofiles. Add sonar-project.properties (pointing at make coverage's cover.out), a sonarcloud job on the Coverage workflow, and a workflow_dispatch shim — matching kollect/mkurator. Preserve CPD exclusions from .sonarcloud.properties. Operator must disable Autoscan and add repo secret SONAR_TOKEN before the first successful upload.
Case default, stderr, [[, merged nested ifs. Align e2e PG-04 meta with workflow read-only floor (a311484); forbid workflow write/admin scopes.
Tighten D-025 read-only floor check; document contract in OpenSpec M04.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apis/{cluster,namespaced}/v1alpha1/register.goinit()(go:S1186 / D-023)config/*_test.go(S3776 / S8205)cover.outreaches Sonar (sonar-project.properties, coverage.yml sonar job, dispatch shim,sonar_pg_09_*)COPYOpenSpec:
openspec/changes/sonar-maintainability-2026-08/(PG-M01…M08).Operator follow-up (non-blocking)
SONAR_TOKENso coverage uploads succeed.Test plan
go test ./config// Dockerfile meta) green before mergemainafter land