🔒 fix: clear GO-2026-5320/5158 vulns and e2e.yaml permission finding - #37
Merged
Conversation
Clears the two Scorecard/govulncheck module-graph findings (both unreachable transitive deps, not in any called path): - GO-2026-5320 XSS in github.com/yuin/goldmark v1.4.13 -> v1.7.17 - GO-2026-5158 baggage parsing in go.opentelemetry.io/otel v1.43.0 -> v1.44.0 govulncheck now reports 0 vulnerabilities. No generated CRD drift from the goldmark parser bump (make generate is a no-op).
Clears Scorecard 'no topLevel permission defined' on e2e.yaml. All three jobs already declare their own permissions, so the top-level contents: read floor strips nothing; it brings e2e.yaml in line with the other workflows.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-v0.3.0 hardening: clears the two open govulncheck/Scorecard vulnerability findings and the one actionable OpenSSF workflow-token finding. Scoped deliberately to changes that make sense and don't alter behavior.
Vulnerabilities (both unreachable transitive deps — govulncheck reports 0 called vulns before and after)
github.com/yuin/goldmark→ bumpedv1.4.13→ v1.7.17go.opentelemetry.io/otel→ bumpedv1.43.0→ v1.44.0 (withotel/trace,otel/metricaligned)govulncheck ./...now reports 0 vulnerabilities.make generateproduces no CRD/docs drift from the goldmark parser jump.OpenSSF / Scorecard token-permissions
permissions: contents: readfloor to.github/workflows/e2e.yaml(was the only workflow lacking a top-level block). All three jobs already declare their own permissions, so the floor strips nothing and matches the other workflows.contents: writeon backport/changelog/tag,statuses: writeon e2e,packages: writeon publish — all required by those jobs.Verification
go build ./...✅go test ./...✅govulncheck ./...✅ 0 vulnerabilitiesmake generate✅ no driftContext
Groundwork for the v0.3.0 release (E8 data-sources epic). The existing lightweight
v0.3.0tag is stale/incomplete and will be re-cut as a signed annotated tag at main HEAD after this lands (operator-gated).