E8-S02: BackupList CRD and observe-only controller - #31
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…angelog
- gofmt internal/controller/{cluster,namespaced}/setup_custom.go
- README: 32 → 33 managed resources (BackupList CRD added)
- docs/api/out.md: regenerated to include BackupList API reference
- go.mod: google.golang.org/grpc v1.79.3 → v1.82.1 (GO-2026-6061)
- CHANGELOG.md: regenerated via git cliff
…deepcopy files - Replace managed.WithExternalConnecter with managed.WithExternalConnector (SA1019) - Suppress GetEventRecorderFor deprecation with nolint; direct replacement breaks compilation until crossplane-runtime migrates NewAPIRecorder to new events API - Remove embedded field selector o.Options.Gate -> o.Gate (QF1008) - Fix goimports import grouping in cluster controller_test.go - Run angryjet: reorder BackupList methods before Clone (alphabetical), add BackupListList.GetItems() to both cluster and namespaced zz_generated.managedlist.go - Run controller-gen: move StorageBackupEntry deepcopy funcs after CloneStatus (alphabetical type ordering) in both cluster and namespaced zz_generated.deepcopy.go
konih
force-pushed
the
e8-s02-backuplist-crd-controller
branch
from
July 28, 2026 19:51
13ec074 to
927ad69
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/clients/gridscale_http.go: thin REST client (GridscaleClient) for the gridscale API, with authenticated GET and configurable base URLBackupListtypes (cluster + namespaced scopes) withStorageUUIDparameter andStorageBackupsobservationobserve-only: Create/Update return errors, Delete is a no-op)internal/controller/cluster/setup_custom.goandinternal/controller/namespaced/setup_custom.goregistering BackupList only (PublicNetwork will be added in E8-S04 after E8-S03 merges)storage.gridscale.platformrelay.io_backuplists.yaml(cluster) andstorage.gridscale.m.platformrelay.io_backuplists.yaml(namespaced)GridscaleClient.Getand cluster BackupList controller (Observe with populated/empty list, Create/Update observe-only error)hack/test/e8_s02_backuplist_crd_exists_test.shNotes on generated files
zz_generated.deepcopy.goandzz_generated.managed.goin both storage packages are bootstrap additions — only BackupList/StorageBackupEntry blocks were spliced in; no existing Clone/StorageImport methods were touched. The source worktree (data-sources-plan) was on a stale branch with type changes in those generated files (ManagedResourceSpec vs ResourceSpec, NamespacedReference vs Reference), so a wholesale copy was not safe. The spliced methods match the patterns already present for Clone and StorageImport in each package.make generate(angryjet + controller-gen) will regenerate these files identically on next run.Gate results
Test plan
kind: CustomResourceDefinitioncmd/provider/main.gonot modified (that's E8-S04)