📝 docs(adr): record the FBC posture and resolve ADR-0708 to Current - #310
Merged
Conversation
The upstream community-operators hosted pipeline emits `check_using_fbc` as a Warning on both open submissions, recommending File-Based Catalogs for new operators. ADR-0708 already rejected in-repo FBC/`opm` (option C, lowest on operability, listed under "Skipped"), but that predates the warning, so nothing recorded that we saw the recommendation and held the line. Add a dated 2026-08-18 note under "Alternatives considered" restating the ADR's own reasoning -- an `opm`-rendered catalog is a second generated artifact to pin and re-render every release, disproportionate for lean solo-maintained release engineering -- plus the concrete triggers that would reopen it: upstream deprecating registry+v1 or hardening the check to an error, the bundle outgrowing hand-templating, or maintenance ceasing to be solo. No FBC adoption: that would reverse a recorded decision and needs a superseding ADR. Resolve the status while here. The operator accepted option A on 2026-08-08 and the track has shipped -- #309 merged, Artifact Hub registered with Verified Publisher active, both community-operators PRs open and green -- so the header and the theme-07 index row move from "Exploring (Proposed)" to Current, the vocabulary this repo uses for an accepted decision. The install-docs tense follows. dist_adr_0708_indexed_test.sh asserted the old status, so it now asserts the new one, anchored to the ADR header line rather than a file-wide grep, and requires the header and the index row to agree so the two cannot drift apart.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The upstream community-operators hosted pipeline emits
check_using_fbcas a Warning on bothopen submissions
(community-operators#9070,
community-operators-prod#10889):
Both submissions are green — the check recommends, it does not block. ADR-0708 had already
considered and rejected in-repo FBC/
opm(option C, lowest on operability, listed under"Skipped"), but the ADR predates the warning, so nothing recorded that we saw the recommendation
and held the line.
What this does
FBC was deliberately NOT adopted. Option C stays rejected on its recorded grounds, not on new
ones: an
opm-rendered catalog is a second generated artifact to pin and re-render every release,on top of the CSV that
hack/test/dist_olm_bundle_test.shalready gates for drift —disproportionate for a solo-maintained project with deliberately lean release engineering
(ADR-0705). The upstream warning introduces no fact the ADR had not already weighed, so no new
rationale was invented. Adopting FBC would reverse a recorded decision and needs a superseding
ADR, not an edit here — that is stated explicitly in the ADR.
The note is a posture, not a permanent refusal. It records concrete revisit triggers: upstream
deprecating registry+v1 or hardening
check_using_fbcinto an error; the bundle outgrowinghand-templating (multiple channels,
skips/replacesgraphs, per-OCP catalog pinning);maintenance ceasing to be solo.
The status flip to
Currentis not a new decision. It propagates a pre-existing maintainerruling from
agent-context/decisions.mddated 2026-08-08 — "ADR-0708 (hub distribution)ACCEPTED: option A, full Artifact Hub + OperatorHub packaging" — that never reached the ADR
header. It is now backed by shipping evidence: PR #309 merged (
e71faaffd), Artifact Hubrepository
kollectregistered with the realrepositoryIDand Verified Publisher active.The independent reviewer corroborated that ruling by confirming PRs #284/#285/#286 merged exactly
as it predicted.
docs/adr/README.md's theme-07 row and theinstall.mdtense follow the header.Gate
hack/test/dist_adr_0708_indexed_test.shasserted the oldExploringstatus, so it now assertsthe new one — and was tightened while there: it pins the ADR header line
(
^\*\*Theme:\*\*.*\*\*Status:\*\*) rather than doing a file-wide grep that would pass on prose,and it requires the header and the index row to agree, so the two can never drift apart. The
index-row comparison is derived from the header rather than pinned to a literal, so it stays
falsifiable. Perturbation-verified five ways.
Verification
Full gate matrix re-run on this head after confirming it sits directly on the
maintip:hack/test/dist_*.sh— passhack/test/docs_*.sh— passpre-commit run --files <the 4 changed files>— pass (10 hooks)task lint:markdown— 148 files, 0 issuesNo code change; no FBC adoption.
Review
Independent review verdict: APPROVE, no P0/P1/P2. Four P3 polish notes recorded as
ADR-NIT-01in the backlog rather than actioned here.