Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/sink/kafka/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package kafka
import (
"context"
"encoding/json"
"errors"
"fmt"
"strings"
"time"
Expand Down Expand Up @@ -143,11 +144,15 @@ func dialTransport(cfg Config) (*kafka.Transport, error) {
if cfg.Username != "" {
mechanism, err := scram.Mechanism(scram.SHA256, cfg.Username, cfg.Password)
if err != nil {
return nil, fmt.Errorf("kafka SASL: %w", err)
return nil, redactedSASLError()
}

transport.SASL = mechanism
}

return transport, nil
}

func redactedSASLError() error {
return errors.New("kafka SASL: authentication configuration failed")
}
27 changes: 27 additions & 0 deletions internal/sink/kafka/sasl_redact_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2026 Konrad Heimel

package kafka

import (
"strings"
"testing"
)

func TestDialTransport_SASLPrepErrorOmitsPassword(t *testing.T) {
t.Parallel()

const secret = "s3cret\x07"
_, err := dialTransport(Config{
Brokers: []string{"127.0.0.1:1"},
Topic: "inventory",
Username: "alice",
Password: secret,
})
if err == nil {
t.Fatal("expected SASL construction error for a prohibited password rune")
}
if strings.Contains(err.Error(), "s3cret") || strings.Contains(err.Error(), secret) {
t.Fatalf("SASL error must not include the password: %q", err.Error())
}
}
Loading