✨ feat(examples): EX-S08 discover packs, wire dogfood into task check - #61
Merged
Conversation
…3-name loop EX-S08: the "which example packs does `assent test` dogfood" list was duplicated by hand across Taskfile.yml's dogfood-examples task, the verify.yaml dogfood step, and a greenExamplePacks Go slice — a proven skew risk when a pack is added. hack/dogfood-examples.sh now discovers every examples/packs/<name> with a .assent/tests directory (mirroring the EX-S01 inventory contract); Taskfile.yml and verify.yaml both call that one script, and greenExamplePacks is derived from the same glob at test time. task check gains a dogfood-wiring-test stage (after build, alongside build itself) so unwiring dogfood-examples from check: reds a pin instead of only failing in CI (REQ-EX-S08-01..05).
3 tasks
konih
added a commit
that referenced
this pull request
Aug 16, 2026
EX-S08 (PR #61) added dogfood-examples and dogfood-wiring-test to Taskfile.yml's check: task, bringing it to 17 stages, but the AUD-S18 exit gate's CHECK_STAGES array still pinned only 15 — silently reddening hack/audit/exitgate_test.sh on every push to main since befce0f (the release-exitgate job only runs on push, so no PR ever saw it). Add the two missing stages in Taskfile order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Taskfile.yml,.github/workflows/verify.yaml, andcmd/assent/test_corpus_test.go'sgreenExamplePacksslice) with a single discovery scripthack/dogfood-examples.shthat walksexamples/packs/*/.assent/testsat runtime and runsassent test+assent test --coverageon each discovered pack.hack/examples/dogfood_wiring_test.shas a wiring pin, asserting thattask checkrunsdogfood-examplesafterbuild, and that bothTaskfile.yml'sdogfood-examplestask andverify.yaml's dogfood step delegate to the shared script rather than a hardcoded loop.TestGreenExamplePacksIsFilesystemDerived,TestBrokenPackFixtureIsNotDiscovered, andTestExampleCorpusDiscoveryMatchesReadmeInventory.dogfood-examplesnow runs intask checksequentially afterbuild.openspec/specs/p5-ex-complex-examples/spec.md).This lane passed independent review with verdict APPROVE (P2/P3 non-blocking notes only, no P0/P1). It has been rebased onto the current
maintip (which includes an unrelated changelog-sync fix), andCHANGELOG.mdwas regenerated (task changelog-write) and amended into the lane commit.Test plan
task check— fully green, includingchangelog-verify,dogfood-examples,dogfood-wiring-test,workflow_pins_test.sh,ci-audit-testtask coverage— 91.1% (required: 91%)dogfood-examplesdiscovers all 3 packs (infra-vars,service-catalog,topic-registry) from the filesystem and runsassent test+assent test --coverageon each — all PASS, all rules covered in both polaritiesdogfood_wiring_test.shconfirm the wiring assertion and the hardcoded-loop detector can both go red