Skip to content

Fix redirectUri for roblox oauth #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raadtotheraad wants to merge 1 commit into from
+2 −2
Closed

Fix redirectUri for roblox oauth #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pages/api/auth/roblox/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default async function handler(req: AuthenticatedRequest, res: NextApiRes
let clientId: string | undefined;
let redirectUri: string | undefined;
clientId = process.env.ROBLOX_CLIENT_ID;
redirectUri = `${process.env.PLANETARY_CLOUD_URL ? `https://${process.env.PLANETARY_CLOUD_URL}` : process.env.NEXTAUTH_URL || process.env.PUBLIC_URL}/api/auth/discord/callback`;
redirectUri = `${process.env.PLANETARY_CLOUD_URL ? `https://${process.env.PLANETARY_CLOUD_URL}` : process.env.NEXTAUTH_URL || process.env.PUBLIC_URL}/api/auth/roblox/callback`;

@coderabbitai coderabbitai Bot Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Reuse the callback’s redirect URI resolution.

pages/api/auth/roblox/callback.ts honors ROBLOX_REDIRECT_URI and instanceConfig.robloxRedirectUri, but this line always derives the URI from base URL variables. When an override is configured, Roblox receives one redirect_uri during authorization and a different one during token exchange, causing the OAuth flow to fail. Use a shared resolver or identical precedence here.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pages/api/auth/roblox/start.ts` at line 18, Update the redirect URI
assignment in the Roblox start handler to use the same resolver and precedence
as the callback handler, including ROBLOX_REDIRECT_URI and
instanceConfig.robloxRedirectUri overrides before base URL fallbacks. Ensure
authorization and token exchange send the identical callback URI, preferably by
reusing the callback’s shared resolver.

if (!clientId || !redirectUri) {
try {
const configs = await prisma.instanceConfig.findMany({
Expand Down Expand Up @@ -55,4 +55,4 @@ export default async function handler(req: AuthenticatedRequest, res: NextApiRes
authUrl.searchParams.set('state', state);

res.redirect(authUrl.toString());
}
}