Get a proper path to the python shared library for the QPD plugin #3012
Merged
Conversation
…d of the static archive when both are avaiable
maliasadi
requested review from
dime10 and
kipawaa
and removed request for
dime10
July 10, 2026 20:15
Contributor
|
Hello. You may have forgotten to update the changelog!
|
dime10
approved these changes
Jul 10, 2026
maliasadi
added
the
author:build-wheels
kipawaa
approved these changes
Jul 13, 2026
kipawaa
left a comment
kipawaa
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @maliasadi !
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
- Coverage 97.23% 96.99% -0.24%
==========================================
Files 39 167 +128
Lines 4481 19436 +14955
Branches 0 1816 +1816
==========================================
+ Hits 4357 18852 +14495
- Misses 124 430 +306
- Partials 0 154 +154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maliasadi
removed
the
author:build-wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The current
get_libpython_path()trustsLDLIBRARY, and if it finds nothing, then it returns an empty string. This causes the QPD plugin fails on envs whenLDLIBRARYsets to the static archived python library instead of the shared one (e.g., on conda envs:LDLIBRARY = libpython3.14.a).This PR fixes this with a minimal patch to
get_libpython_path()that it now only acceptsLDLIBRARYwhen it's actually a shared object, and otherwise falls back to the conventionallibpython{LDVERSION}.soinLIBDIR. This fixes the issues on conda envs while preserving the current behaviour on other envs.Benefits:
Possible Drawbacks:
n/a
Related GitHub Issues:
[sc-124573]