Modernize secrets-init and remediate gRPC authorization bypass #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,76 @@ | ||
| name: github | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - '[0-9]+.[0-9]+.[0-9]+' | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '*.md' | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 30 | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 | ||
| with: | ||
| go-version: '1.26.5' | ||
| cache: true | ||
|
|
||
| - name: Validate release tag | ||
| env: | ||
| RELEASE_TAG: ${{ github.ref_name }} | ||
| run: | | ||
| set -euo pipefail | ||
| if [[ ! "$RELEASE_TAG" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| printf 'invalid release tag: %s\n' "$RELEASE_TAG" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Read source date | ||
| id: source | ||
| env: | ||
| SOURCE_COMMIT: ${{ github.sha }} | ||
| run: printf 'date=%s\n' "$(git show -s --format=%cI "$SOURCE_COMMIT")" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Cross-platform build | ||
| env: | ||
| BRANCH: ${{ github.ref_name }} | ||
| COMMIT: ${{ github.sha }} | ||
| DATE: ${{ steps.source.outputs.date }} | ||
| VERSION: ${{ github.ref_name }} | ||
| run: make platform-build | ||
|
|
||
| - name: Generate checksums | ||
| run: ./scripts/write-checksums.sh .bin | ||
|
|
||
| - name: Build Changelog | ||
| id: build_changelog | ||
| uses: mikepenz/release-changelog-builder-action@c9bcd8238b6f41e05561348339429d360b1c0247 # v6 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Create Release | ||
| uses: softprops/action-gh-release@3d0d9888cb7fd7b750713d6e236d1fcb99157228 # v3 | ||
| with: | ||
| body: ${{ steps.build_changelog.outputs.changelog }} | ||
| fail_on_unmatched_files: true | ||
| files: | | ||
| .bin/* | ||
| overwrite_files: false | ||
| tag_name: ${{ github.ref_name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,52 @@ | ||
| name: test | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - '**' | ||
|
ibrahimlawal-paystack marked this conversation as resolved.
|
||
| tags: | ||
| - '**' | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '*.md' | ||
| pull_request: | ||
| branches: | ||
| - '**' | ||
| env: | ||
| GOPROXY: https://proxy.golang.org | ||
| CGO_ENABLED: 0 | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 20 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6 | ||
| with: | ||
| go-version: '1.26.5' | ||
| cache: true | ||
|
|
||
| - name: Build release artifacts | ||
|
ibrahimlawal-paystack marked this conversation as resolved.
|
||
| run: make platform-build | ||
|
|
||
| - name: Generate release checksums | ||
| run: ./scripts/write-checksums.sh .bin | ||
|
|
||
| - name: Build container image | ||
| run: docker build --tag secrets-init:ci . | ||
|
|
||
| - name: Smoke test container image | ||
| run: docker run --rm secrets-init:ci --version | ||
|
|
||
| - name: Race test | ||
| run: make CGO_ENABLED=1 test-race | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot review: [P1] Serialize all release publication
${{ github.workflow }}-${{ github.ref }}gives the Docker and GitHub release workflows different groups and also lets different tags publish concurrently. An older tag can therefore finish last and move the mutablelatesttags backward while release artifacts are being published independently. Use one repository-wide publication key and explicit ordering for every release workflow/tag.