Add msp_google_native and msp_google_banner bidder names - #133
Merged
Conversation
Register two Google sibling bidder names so MSP can call the Google adapter separately per format, following the existing MSP bidder pattern (const in the MSP-extension block + entry in mspBidderNames()). Both are served by the existing msp_google.so; the MSP side supplies native-only / banner-only bidder-info and the per-env adapter config. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fushouli
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register two Google sibling bidder names,
msp_google_nativeandmsp_google_banner, so MSP can call the Google adapter separately per format.Follows the existing MSP bidder pattern established by #131 (
msp_bidease):openrtb_ext/bidders.gomspBidderNames()inopenrtb_ext/msp_bidders.goBoth names are served by the existing
msp_google.so, the same waymsp_moloco_nativesharesmsp_moloco.so. The MSP-side PR supplies the native-only / banner-onlybidder-info, thebidder-paramsschemas, and the per-envadapters.*config, and bumps the submodule pointer to this commit.Testing
go build ./openrtb_ext/...andgo vet ./openrtb_ext/cleango test ./openrtb_ext/... ./config/...passTestBidderInfoFilespasses against the MSP static files. Verified that test has teeth: adding an unregistered bidder-info file makes it fail withunknown bidder, so a green run is real evidence both new names resolve.🤖 Generated with Claude Code