Couple UX improvements#8
Open
avargaskun wants to merge 4 commits into
Open
Conversation
- On iOS the keyboard is displayed automatically when the dialog is shown - This change makes it work the same way on Android
- Do not callback into the Cordova application until dialog is dismissed - Otherwise, UI elements shown after the callback get dismissed along with the dialog
UIAlertView is deprecated and, on the cordova-ios 8 UIScene lifecycle, instantiating it throws NSObjectNotAvailableException -> SIGABRT. Rewrite prompt: with UIAlertController, preserving the exact JS contract (1-based buttonIndex by position, input1, success-only result). Drop the UIAlertViewDelegate conformance and delete the old delegate callback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The action handlers captured the alert strongly to read its text field, forming an alert->action->handler->alert cycle that leaked one controller per prompt. Capture the alert weakly instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS
Android