fix(ui): cosmetic polish — red required markers, BMI legend alignment, autocomplete position, labels - #442
Open
gkbishnoi07 wants to merge 8 commits into
Open
fix(ui): cosmetic polish — red required markers, BMI legend alignment, autocomplete position, labels#442gkbishnoi07 wants to merge 8 commits into
gkbishnoi07 wants to merge 8 commits into
Conversation
[5] First-visit indicator now uses theme blue (primary) not green (success) in the shared beneficiary worklist (row border + legend swatch); revisit stays warning. [17] Adult BMI status legend vertically centered beside the BMI input. [24][23] Prescription labels capitalized in English.json: dosage -> Dosage, route -> Route (shared key, also fixes Route elsewhere), add -> Add. [29] Reworded the NCD-screening family-history instruction to "Please select any NCD for proper screening" per QA.
- Family History: mark Family Member with zRequired so it shows the red * (it becomes required when a disease is chosen). - BMI status legend: pad the adult status cell down on wide screens so "Obesity/Overweight/..." aligns with the BMI input's middle, not the row top.
The NCD-screening family history uses family-history-ncdscreening (not the general family-history). Mark its Family Member with zRequired (red *) and make the existing Disease Type "*" red (text-destructive) so both required markers show consistently.
Original: General OPD marked neither Disease Type nor Family Member (optional); NCD screening marked Disease Type required when age>=30 only. - General OPD family history: remove the Family Member red * (back to optional/unmarked, matching main + the reverted validation). - NCD screening family history: Family Member red * is now conditional on age>=30 to match Disease Type (consistent pair) instead of an always-on marker.
…screens QA [26]: every required-field * should render red. Wrapped the remaining bare asterisks in text-destructive so they match the zRequired styling used elsewhere: general-examination (type of edema), general-opd-diagnosis + covid-diagnosis (provisional/doctor diagnosis), quick-consult (provisional diagnosis), travel-history (travelled last 14 days), general-refer (institute + referral reason). Cosmetic only — the conditional show/hide logic is unchanged.
The previous justify-center + lg:pt-7 approach guessed the offset and left the
badge ("Obesity" etc.) sitting above the input's vertical center. Replace it with
an invisible z-form-label spacer (exact sibling-label height) + gap-1.5 + a
min-h-9 box that centers the badge — so it lines up on the input's vertical
center with no magic numbers. Applied to both general and cancer patient vitals.
…D-screening diagnosis) QA [21]/[24]: mandatory sign must be red everywhere. A comprehensive sweep found two bare asterisks still rendering black — the lab-technician "Mandatory *" hint and the NCD-screening-diagnosis provisional-diagnosis marker. Wrapped both in text-destructive to match the rest of the app. Cosmetic only.
…nput QA [16]: the suggestion panel overlapped its own input. In these two components the listbox is a direct child of z-form-field (position:relative), which also holds the label — as a flex column with the panel out of flow and no explicit top, it snapped to the top of the field, covering the input. Anchor it explicitly with left-0 top-full so it drops directly below the input (matching the div.relative-wrapped autocompletes in the diagnosis/prescription/quick-consult screens). Layout-only.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
drtechie
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A batch of cosmetic / layout QA fixes across nurse-doctor and lab screens.
*markers red everywhere — wrapped remaining black asterisks intext-destructive(family history, general examination, diagnosis, quick-consult, travel history, refer, lab workarea "Mandatory *", NCD-screening diagnosis). (QA: mandatory sign should be same, it is black.)ptguess. Applied to general + cancer vitals. (QA)top-full left-0so it drops below the input. (QA: dropdowns overlapping input/search fields.)Testing
Verify the affected screens: all required
*render red; adult BMI badge is centered on the input; Chief-Complaint / Findings suggestions drop cleanly below the input; first-visit is blue; prescription labels capitalized.