Skip to content

Sn/fix pharmacist inventory redirect - #285

Merged
snehar-nd merged 2 commits into
vb/hwc-3.8.1from
sn/fix-pharmacist-inventory-redirect
Aug 13, 2026
Merged

Sn/fix pharmacist inventory redirect#285
snehar-nd merged 2 commits into
vb/hwc-3.8.1from
sn/fix-pharmacist-inventory-redirect

Conversation

@snehar-nd

Copy link
Copy Markdown
Contributor

📋 Description

JIRA ID:

AMM-2417

✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Sneha and others added 2 commits August 4, 2026 12:03
InventoryService.current_language_set was declared but never
assigned, so the guard's error-alert branch threw instead of
showing a message whenever authKey/facility/host was missing —
masking the real problem and making the redirect look like a
no-op. Populate it from HttpServiceService.currentLangugae$, the
same pattern AuthGuard already uses.

Also guard getppID() against a missing serviceLineDetails entry
(JSON.parse(null).parkingPlaceID threw before the redirect could
fire), and fix the setLanguage fallback check in worklist.component
(sessionStorage.getItem returns null, never undefined).
…sis autocomplete

The panel-fill bootstrap logic proactively fetched extra pages whenever the
dropdown didn't scroll, flipping noMore to true almost immediately. Now
"End of results" only shows when a real fetch (initial search or
scroll-triggered page) actually returns an empty response.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ff07930-1714-4136-aba1-46450f1d5e49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@snehar-nd
snehar-nd merged commit 9e9fb5e into vb/hwc-3.8.1 Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants