fix(doctor-worklist): guard against undefined success message in care-context popup - #284
Open
snehar-nd wants to merge 18 commits into
Open
fix(doctor-worklist): guard against undefined success message in care-context popup#284snehar-nd wants to merge 18 commits into
snehar-nd wants to merge 18 commits into
Conversation
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 4.6.0 to 5.12.0. - [Release notes](https://github.com/jasmine/jasmine/releases) - [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md) - [Commits](jasmine/jasmine@v4.6.0...v5.12.0) --- updated-dependencies: - dependency-name: jasmine-core dependency-version: 5.12.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
fix: amm-2192 remove mandatory for prescription
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix incorrect !== operators to = in service-point.component.ts ngOnInit - Remove debug console.log statements from service-point and service components - Fix typo: locationGathetingIssues to locationGatheringIssues - Fix typo: Seperated to Separated in registrar test files
…aphicsToStorage - Add return statements after locationGatheringIssues() calls in both service-point.component.ts and service.component.ts - Prevents runtime errors when data or data.stateMaster is null/undefined - Addresses CodeRabbit review findings
Release 3.6.1 to main
- Remove unused subscription to currentLangugae$ that accumulated over time - Remove unused HttpServiceService injection and imports - Simplify AuthGuard to focus only on session validation - Fixes memory leak on every route activation across 7 protected routes Closes issue #138
Merge Relase 3.6.2 with Main
…re-5.12.0 build(deps-dev): bump jasmine-core from 4.6.0 to 5.12.0
fix: Remove unmanaged subscription memory leak in AuthGuard
…-and-typos fix: correct assignment operators and fix typos in service components
docs: add CONTRIBUTING.md guide for HWC-UI contributors
…-context popup After a beneficiary returns from the lab and the doctor clicks Update, getHealthIDDetails() concatenated res.data.response directly into the popup text. When that field was falsy, `undefined + '. '` rendered the literal word "undefined" in the success dialog. Fall back to a proper success string, matching the pattern already used by the initial Save flow. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe care-context confirmation prompt now uses the API success response when available. It falls back to the localized success message or a literal default when the response is nullish. ChangesCare-context confirmation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
vanitha1822
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
getHealthIDDetails()inworkarea.component.tsbuilds the popup text viasuccessResponseFromAPI + '. ' + .... The Update flow passesres.data.responseinto this function with no fallback (unlike the initial Save flow, which always supplies a hardcoded fallback string). Whenever that API field was falsy,undefined + '. 'coerced to the literal string"undefined. "in the dialog.datafillSuccessfullytranslation key the Save flow already relies on), so the popup always shows a real success message regardless of the response shape.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit