[Frontend] Remove the dead convert_index floor/mod codegen path#303
Merged
Conversation
axis-split's affine-only contract (docs/axis-split-scheduling.md) linearizes aligned FloorDiv/ModularIndexing into per-axis affine indices upstream, so the load/store index reaching codegen is already pure affine. The convert_index method (which lowered floor/mod view indices to affine.apply with a constant divisor and a single free symbol) and the helper that guarded it are therefore dead -- a tripwire at every floor/mod branch never fired across the view/op test suite. Remove convert_index entirely and inline its only live behaviour at the call sites in _convert_sympy_to_mlir_expr and parse_index_list. A residual FloorDiv/ModularIndexing now fails loudly via the whole-expression guard in each of those functions (mirroring the DMA-index assert) instead of silently mis-lowering. Also drop the assumption-stripping Symbol(str(...)) + expr.replace round-trip in the affine-map builder: it only mattered when convert_index transformed the term, and is now a verified no-op (indices and the affine string depend only on symbol names). Drop the now-unused re import. Verified: the full view/reshape/transpose suite (test_floormod_axis_split incl. group_norm/repeat/repeat_interleave/mixed-radix/pixel_shuffle, transpose2D/3D, view3D_2D, cat) plus add/matmul/reduce/softmax/layernorm/batchnorm pass unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfwHCV7TaX4s9xkn8i7anG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebase of the dead-code-removal commit from #271 onto develop, standalone.
axis-split's affine-only contract (docs/axis-split-scheduling.md) linearizes aligned FloorDiv/ModularIndexing into per-axis affine indices upstream, so the load/store index reaching MLIR codegen is already pure affine. The
convert_indexmethod (which lowered floor/mod view indices to affine.apply with a constant divisor and a single free symbol) and the helper guarding it are therefore dead. This mirrors the assert the DMA-index path already carries; here it makes the load/store affine-index path consistent with it.Removes
convert_index, inlines its only live behaviour at the call sites, and replaces the floor/mod branches with a loud NotImplementedError so any residual floor/mod that escapes axis-split fails instead of silently mis-lowering. Drops the now-unusedreimport.Verification (on develop + this commit)
Cherry-pick onto latest develop is clean (auto-merge, no conflict). The view/reshape/transpose suite passes end-to-end and the new guard never fires:
Total 33 passed, 0 failed; no NotImplementedError raised.
🤖 Generated with Claude Code
https://claude.ai/code/session_018yhfJ2Vw9fWagy6QWrNhi2