Skip to content

chore: 更新杂志主页地址 - #3507

Open
CreeperIsASpy wants to merge 2 commits into
PCL-Community:devfrom
CreeperIsASpy:chore/update-mgh-addr
Open

chore: 更新杂志主页地址#3507
CreeperIsASpy wants to merge 2 commits into
PCL-Community:devfrom
CreeperIsASpy:chore/update-mgh-addr

Conversation

@CreeperIsASpy

@CreeperIsASpy CreeperIsASpy commented Aug 6, 2026

Copy link
Copy Markdown

Meloong-Git/PCL#8180

Summary by Sourcery

改进:

  • 更新杂志主页预设配置,以便从新的 GitHub 支持的 URL 加载内容。
Original summary in English

Summary by Sourcery

Enhancements:

  • Refresh the magazine homepage preset configuration to load content from the new GitHub-backed URL.
Original summary in English

Summary by Sourcery

改进:

  • 更新杂志主页预设配置,以便从新的 GitHub 支持的 URL 加载内容。
Original summary in English

Summary by Sourcery

Enhancements:

  • Refresh the magazine homepage preset configuration to load content from the new GitHub-backed URL.

Signed-off-by: CreeperIsASpy <creeperspy@qq.com>
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels Aug 6, 2026
@sourcery-ai

sourcery-ai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
审阅者指南(在小型 PR 上折叠)

审阅者指南

此 PR 更新了杂志首页使用的预设 URL,使其现在从新的基于 GitHub 的端点加载,而不是之前的自定义主机。

更新后的杂志首页 URL 加载序列图

sequenceDiagram
    participant PageLaunchRight
    participant GitHubProxy

    PageLaunchRight->>PageLaunchRight: RefreshReal()
    PageLaunchRight->>PageLaunchRight: LogWrapper.Info
    PageLaunchRight->>GitHubProxy: LoadFromNetwork("https://gh-proxy.com/https://github.com/CreeperIsASpy/Magazine-Homepage-PCL/raw/main/output/Custom.xaml")
    GitHubProxy-->>PageLaunchRight: Custom.xaml content
    PageLaunchRight->>PageLaunchRight: [render magazine homepage]
Loading

文件级变更

变更 详情 文件
更新杂志首页预设 URL,使其指向新的端点。
  • 修改在 RefreshReal 中选择 case 7 时使用的杂志首页硬编码 URL。
  • 确保首页内容现在通过 gh-proxy 从 Magazine-Homepage-PCL GitHub 仓库加载。
Plain Craft Launcher 2/Pages/PageLaunch/PageLaunchRight.xaml.cs

技巧与命令

与 Sourcery 交互

  • 触发新的审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 通过回复某条审阅评论,让 Sourcery 从该评论创建一个 issue。你也可以回复审阅评论并添加 @sourcery-ai issue 来从中创建 issue。
  • 生成 pull request 标题: 在 pull request 标题中的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来随时(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 内容中的任意位置写上 @sourcery-ai summary,即可在你希望的确切位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来随时(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不再希望看到它们,这将非常有用。
  • 关闭所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可关闭所有已有的 Sourcery 审阅。如果你希望从一个新的审阅开始,这尤其有用——别忘了再评论 @sourcery-ai review 来触发新的审阅!

自定义你的体验

访问你的 仪表盘 以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅指引。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the preset URL used for the magazine homepage so it now loads from the new GitHub-based endpoint instead of the previous custom host.

Sequence diagram for updated magazine homepage URL loading

sequenceDiagram
    participant PageLaunchRight
    participant GitHubProxy

    PageLaunchRight->>PageLaunchRight: RefreshReal()
    PageLaunchRight->>PageLaunchRight: LogWrapper.Info
    PageLaunchRight->>GitHubProxy: LoadFromNetwork("https://gh-proxy.com/https://github.com/CreeperIsASpy/Magazine-Homepage-PCL/raw/main/output/Custom.xaml")
    GitHubProxy-->>PageLaunchRight: Custom.xaml content
    PageLaunchRight->>PageLaunchRight: [render magazine homepage]
Loading

File-Level Changes

Change Details Files
Update the magazine homepage preset URL to point to the new endpoint.
  • Change the hard-coded magazine homepage URL used when case 7 is selected in RefreshReal.
  • Ensure the homepage content is now loaded via gh-proxy from the Magazine-Homepage-PCL GitHub repository.
Plain Craft Launcher 2/Pages/PageLaunch/PageLaunchRight.xaml.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里给出了一些总体反馈:

  • 建议避免在这里使用硬编码的 IP 地址和端口;改用可配置的端点或域名,可以让将来的修改更容易,也能降低出错或服务中断的风险。
  • 如果可能的话,新主页 URL 最好使用 HTTPS 而不是 HTTP,以避免混合内容问题,并在加载远程 XAML 时提高安全性。
给 AI Agent 的提示
请根据本次代码评审的意见进行修改:

## 总体意见
- 建议避免在这里使用硬编码的 IP 地址和端口;改用可配置的端点或域名,可以让将来的修改更容易,也能降低出错或服务中断的风险。
- 如果可能的话,新主页 URL 最好使用 HTTPS 而不是 HTTP,以避免混合内容问题,并在加载远程 XAML 时提高安全性。

Sourcery 对开源项目是免费的——如果你喜欢我们的评审,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • Consider avoiding a hard-coded IP address and port here; using a configurable endpoint or domain name will make future changes easier and reduce the risk of breakage.
  • If possible, prefer HTTPS over HTTP for the new homepage URL to avoid mixed-content issues and improve security when loading remote XAML.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding a hard-coded IP address and port here; using a configurable endpoint or domain name will make future changes easier and reduce the risk of breakage.
- If possible, prefer HTTPS over HTTP for the new homepage URL to avoid mixed-content issues and improve security when loading remote XAML.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MoYuan-CN

Copy link
Copy Markdown
Member

怎么事 IP + HTTP

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb489d04eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Plain Craft Launcher 2/Pages/PageLaunch/PageLaunchRight.xaml.cs Outdated
@MoYuan-CN
MoYuan-CN marked this pull request as draft August 6, 2026 04:47
@pcl-ce-automation pcl-ce-automation Bot added 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Aug 6, 2026
@MoYuan-CN

Copy link
Copy Markdown
Member

Tip

由于在下一个发版周期前内容拥有者将继续做出改动,在改动结束前保留此 PR 不予合并
Since the content owners will keep making changes before the next release cycle,
this PR will stay open (as draft) and won't be merged until the changes are done.

@CreeperIsASpy

Copy link
Copy Markdown
Author

现已改动完成。
接下来,https://gh-proxy.com/https://github.com/CreeperIsASpy/Magazine-Homepage-PCL/raw/main/output/Custom.xaml 将会是杂志主页的永久地址,不会再行更改。

@CreeperIsASpy
CreeperIsASpy marked this pull request as ready for review August 8, 2026 10:06
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 and removed 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 labels Aug 8, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里提供了一些整体性的反馈:

  • 建议将杂志主页的 URL 抽取成配置或常量,这样未来端点发生变化时,就不需要修改这一逻辑块中的代码。
  • 由于新的 URL 引入了额外的代理跳转(gh-proxy + GitHub raw),你可能需要在这里新增或复用错误处理/回退路径,以防代理或 GitHub 不可用或响应缓慢。
给 AI Agent 的提示
Please address the comments from this code review:

## Overall Comments
- Consider extracting the magazine homepage URL into a configuration or constant so future endpoint changes don’t require code modifications in this logic block.
- Since the new URL introduces an additional proxy hop (gh-proxy + GitHub raw), you may want to add or reuse an error-handling/fallback path here in case the proxy or GitHub becomes unavailable or slow.

Sourcery 对开源项目免费使用——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • Consider extracting the magazine homepage URL into a configuration or constant so future endpoint changes don’t require code modifications in this logic block.
  • Since the new URL introduces an additional proxy hop (gh-proxy + GitHub raw), you may want to add or reuse an error-handling/fallback path here in case the proxy or GitHub becomes unavailable or slow.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the magazine homepage URL into a configuration or constant so future endpoint changes don’t require code modifications in this logic block.
- Since the new URL introduces an additional proxy hop (gh-proxy + GitHub raw), you may want to add or reuse an error-handling/fallback path here in case the proxy or GitHub becomes unavailable or slow.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS PR 大小评估:微型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants