-
-
Notifications
You must be signed in to change notification settings - Fork 4
Added Property-Parameter to SkillSelectOptionCategoryPrerequisite #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7828d6b
Added Property-Parameter to SkillSelectOptionCategoryPrerequisite
Lector 33af97a
Merge branch 'main' into feature/select-option-property
Lector 25c6ff4
Property filter in spellwork select options is now an enum as a param…
Lector 6a2ce4a
correction
Lector 0ee19d8
removed unnessesarc import
Lector 8644905
Rename
Lector 8c5f5fd
prettier
Lector 03001a3
fix cache
elyukai 66aef46
Merge branch 'main' into feature/select-option-property
elyukai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import * as DB from "tsondb/schema/dsl" | ||
| import { PropertyIdentifier } from "../../_Identifier.js" | ||
| import { DisplayOption } from "../DisplayOption.js" | ||
|
|
||
| export const PropertyPrerequisite = DB.TypeAlias(import.meta.url, { | ||
| name: "PropertyPrerequisite", | ||
| comment: "Requires a specific property or one of a specific set of properties.", | ||
| type: () => | ||
| DB.Object({ | ||
| id: DB.Required({ | ||
| comment: "The property�s identifier.", | ||
| type: PropertyIdentifier(), | ||
| }), | ||
| display_option: DB.Optional({ | ||
| type: DB.IncludeIdentifier(DisplayOption), | ||
| }), | ||
| }), | ||
| }) | ||
|
Comment on lines
+5
to
+18
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ich schätze mal, dass hier die Einrückung nicht passt und er deswegen meckert. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde
Identifiervielleicht eherSingleoder so nennen, da ja auch die Property ein Identifier ist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist umgesetzt.