Reject CaseSensitive on predicate types that don't support it#627
Merged
Conversation
andrewstillv15
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterPredicate.validateCaseSensitivity()only rejected aCaseSensitivevalue when it wastrue. Afalsevalue on a predicate type that doesn't support case sensitivity (e.g.exists,matches) passed validation and was sent to the API, which ignores it and returnsnull. Any client that round-trips the response — like terraform-provider-opslevel — then sees the value it set silently disagree with the API, surfacing in Terraform as "Provider produced inconsistent result after apply".This drops the
&& *filterPredicate.CaseSensitiveclause soValidate()rejects any non-nilCaseSensitive(true or false) for these types.nilremains valid (handled by the existing early return).Changes
validateCaseSensitivitynow rejects any non-nilCaseSensitiveonknownNotCaseSensitiveTypes, with a comment explaining the API ignores/nulls the value. Error message unchanged.TestFilterPredicateValidateCaseSensitivityexercisingValidate()end to end: nil/true/false on a not-case-sensitive type (repository_ids+exists) and true/false on a case-sensitive type (language+equals).Bugfixentry.Verification
false-value test case fails before the code change and passes after.go test -race ./...→okgofumpt -d -e .→ clean;golangci-lint run→0 issuesRefs
validateCaseSensitivityto catch nil-returning cases)