fix: comprehensive audit, bug fixes, and documentation overhaul - #12
fix: comprehensive audit, bug fixes, and documentation overhaul#12JarbasAl wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of changes: - Fixed paragraph_tokenize crash on leading newlines. - Fixed get_empty_spans indexing for trailing spaces. - Added regex escaping for delimiters in chunk function. - Improved _WORD_REGEX to handle version numbers, emails, and hyphenated words. - Refactored span indexing logic for sentences and paragraphs to be more robust. - Added extensive test suite in test/test_extensive.py. - Created /docs directory with Getting Started and API Reference guides. - Modernized README.md with features and better examples. AI-Generated Change: - Model: Gemini 2.0 Flash - Intent: Audit codebase, fix edge cases, and add comprehensive documentation. - Impact: Improved reliability and developer experience. - Verified via: PYTHONPATH=. pytest test/test_chunking.py test/test_extensive.py
Replace the broken `python setup.py bdist_wheel` step (setuptools is no longer bundled on modern Python) with PEP 517 `python -m build`, drop the tflite and nonexistent-extras install steps copied from ovos-core, and run the real unit test suite across a 3.10-3.12 matrix. Add MANIFEST.in so the sdist includes requirements.txt, which setup.py reads at build time.
7589cf0 to
e63cf97
Compare
The bespoke workflow installed lichecker from a git URL and drove it via test/license_tests.py. lichecker calls normalize_license_name() on the value it reads from package metadata, so any dependency publishing no license field raises AttributeError on None before a whitelist is ever consulted -- `regex` publishes neither a License field nor a license classifier, which crashed the job outright. Delegate to the reusable license-check workflow like the rest of the ecosystem. It carries the audited central whitelist and tolerates missing metadata instead of crashing on it.
Summary
Test plan
AI Usage Disclaimer
Gemini 2.0 Flash. Human reviewed before merge.
🤖 Generated with Gemini CLI