feat: support sftool stub bin and config - #53
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for configuring an external sftool stub binary and/or stub_config JSON at the workspace level, exposes the configuration via a new command and sidebar entry, and injects the resulting flags into the generated sftool download command.
Changes:
- Introduce
buildSftoolStubArgshelper and unit tests for generating--stub/--stub-configflags. - Persist stub bin / config paths in
WorkspaceStateService, add a new “Configure sftool Stub” command + QuickPick UI, and surface status in the sidebar. - Append configured stub arguments into the
sftooldownload command construction.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/sftoolCommandUtils.ts | New helper for quoting and building sftool stub-related CLI args. |
| src/test/sftoolCommandUtils.test.ts | Unit tests covering stub-arg construction behavior. |
| src/services/workspaceStateService.ts | Add workspace state fields/keys + getters/setters for stub bin/config paths. |
| src/services/boardService.ts | Inject stub args into the generated sftool download command. |
| src/providers/sifliSidebarProvider.ts | Add sidebar item + status/tooltip for current stub configuration and refresh triggers. |
| src/extension.ts | Register new extension.configureSftoolStub command. |
| src/commands/configCommands.ts | Implement QuickPick-driven configuration flow for stub settings. |
| package.json | Contribute the new command to VS Code. |
| package.nls.json | Localized title for the new command (en). |
| package.nls.zh-cn.json | Localized title for the new command (zh-cn). |
| l10n/bundle.l10n.json | Runtime string localizations for the new stub UI (en). |
| l10n/bundle.l10n.zh-cn.json | Runtime string localizations for the new stub UI (zh-cn). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+8
| export function quoteSftoolCommandArg(value: string): string { | ||
| return `"${value}"`; | ||
| } |
HalfSweet
force-pushed
the
feat/sftool-stub-config
branch
from
June 11, 2026 08:34
08ad1a8 to
4850bb4
Compare
HalfSweet
force-pushed
the
feat/sftool-stub-config
branch
from
June 11, 2026 08:37
4850bb4 to
18021ef
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support sftool stub bin and config