Skip to content

chore: Spice86 v15.0.0 major NuGet release + auto prerelease NuGet on master - #2267

Merged
maximilien-noal merged 5 commits into
masterfrom
copilot/enable-auto-release-of-prerelease-nugets
Jul 20, 2026
Merged

chore: Spice86 v15.0.0 major NuGet release + auto prerelease NuGet on master#2267
maximilien-noal merged 5 commits into
masterfrom
copilot/enable-auto-release-of-prerelease-nugets

Conversation

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

  • src/Directory.Build.props – Normalize version to full semver 15.0.0, add explicit AssemblyVersion/FileVersion (15.0.0.0), update PackageReleaseNotes link to v15 wiki page.
  • .github/workflows/prerelease.yml – Replace hardcoded base version 11.0.0 with a dynamic read from Directory.Build.props; prerelease packages now version as {Version}-{sha} and auto-track future bumps.
  • Tag v15.0.0 – Annotated tag created on this branch; push to origin after merge: git push origin v15.0.0.

Rationale behind Changes

<Version> was set as bare 15 with no AssemblyVersion/FileVersion, and the release notes link still pointed at v14. The prerelease workflow hardcoded 11.0.0 as its base, producing stale NuGet identifiers unrelated to the actual project version.

Suggested Testing Steps

After merge:

  1. git push origin v15.0.0
  2. Verify the prerelease workflow publishes packages versioned 15.0.0-<sha> to GitHub Packages.
  3. Create the Spice86-v15-release-notes wiki page.

@maximilien-noal
maximilien-noal marked this pull request as ready for review July 20, 2026 16:56
Copilot AI review requested due to automatic review settings July 20, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the Spice86 codebase for the v15.0.0 NuGet release and makes the prerelease packaging workflow track the project’s declared version automatically.

Changes:

  • Normalizes the package <Version> to full SemVer (15.0.0) and sets explicit AssemblyVersion/FileVersion to 15.0.0.0.
  • Updates NuGet release notes URL to the v15 wiki page.
  • Updates the prerelease workflow to derive its base version from src/Directory.Build.props instead of a hardcoded value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Directory.Build.props Sets v15 SemVer + explicit assembly/file versions and updates release notes link.
.github/workflows/prerelease.yml Derives prerelease version from Directory.Build.props and appends short commit SHA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/prerelease.yml
Comment thread .github/workflows/prerelease.yml Outdated
Comment thread .github/workflows/prerelease.yml Outdated
@maximilien-noal

Copy link
Copy Markdown
Member

#2267 (review)

@copilot implement changes based on this feedback

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

#2267 (review)

@copilot implement changes based on this feedback

Done in commit chore: bump checkout/setup-dotnet to v4, replace grep -P with awk:

  • actions/checkout@v1@v4
  • actions/setup-dotnet@v1@v4
  • grep -oPm1 "(?<=<Version>)..." replaced with awk -F'[<>]' '/<Version>/{print $3; exit}' (no PCRE dependency)

@maximilien-noal
maximilien-noal self-requested a review July 20, 2026 19:38

@maximilien-noal maximilien-noal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot for a new nuget regular release to be made, you must bump to v16 !

and the master branch is protected. I want a new NUGET prerelease too on each PR merge.

The github prerelease is nice, but out of what I truly want.

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot for a new nuget regular release to be made, you must bump to v16 !

and the master branch is protected. I want a new NUGET prerelease too on each PR merge....

Done in commit chore: bump to v16, remove binary release steps from prerelease workflow:

  • Version bumped to 16.0.0 (AssemblyVersion/FileVersion to 16.0.0.0) and release notes link updated to the v16 wiki page.
  • The binary build, zip, and GitHub release steps have been removed from the prerelease workflow. On every push to master (i.e. every merged PR), the workflow now runs tests, packs, and publishes NuGet prerelease packages versioned 16.0.0-{sha} to GitHub Packages — nothing else.
  • permissions.contents downgraded to read since the workflow no longer creates GitHub releases.

@maximilien-noal maximilien-noal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot keep the github prerelease workflow !!

Copilot AI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot keep the github prerelease workflow !!

Restored in commit chore: restore binary build and GitHub prerelease steps in prerelease workflow. The binary build, zip, and GitHub prerelease release steps are back alongside the NuGet publishing.

@maximilien-noal
maximilien-noal merged commit 5a38014 into master Jul 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants