chore: Spice86 v15.0.0 major NuGet release + auto prerelease NuGet on master - #2267
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the Spice86 codebase for the v15.0.0 NuGet release and makes the prerelease packaging workflow track the project’s declared version automatically.
Changes:
- Normalizes the package
<Version>to full SemVer (15.0.0) and sets explicitAssemblyVersion/FileVersionto15.0.0.0. - Updates NuGet release notes URL to the v15 wiki page.
- Updates the prerelease workflow to derive its base version from
src/Directory.Build.propsinstead of a hardcoded value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Directory.Build.props |
Sets v15 SemVer + explicit assembly/file versions and updates release notes link. |
.github/workflows/prerelease.yml |
Derives prerelease version from Directory.Build.props and appends short commit SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot implement changes based on this feedback |
Done in commit
|
maximilien-noal
left a comment
There was a problem hiding this comment.
@copilot for a new nuget regular release to be made, you must bump to v16 !
and the master branch is protected. I want a new NUGET prerelease too on each PR merge.
The github prerelease is nice, but out of what I truly want.
Done in commit
|
maximilien-noal
left a comment
There was a problem hiding this comment.
@copilot keep the github prerelease workflow !!
Restored in commit |
Description of Changes
src/Directory.Build.props– Normalize version to full semver15.0.0, add explicitAssemblyVersion/FileVersion(15.0.0.0), updatePackageReleaseNoteslink to v15 wiki page..github/workflows/prerelease.yml– Replace hardcoded base version11.0.0with a dynamic read fromDirectory.Build.props; prerelease packages now version as{Version}-{sha}and auto-track future bumps.v15.0.0– Annotated tag created on this branch; push to origin after merge:git push origin v15.0.0.Rationale behind Changes
<Version>was set as bare15with noAssemblyVersion/FileVersion, and the release notes link still pointed at v14. The prerelease workflow hardcoded11.0.0as its base, producing stale NuGet identifiers unrelated to the actual project version.Suggested Testing Steps
After merge:
git push origin v15.0.0prereleaseworkflow publishes packages versioned15.0.0-<sha>to GitHub Packages.