editoast: core_task: remove lock on valkey connection#17536
Open
flomonster wants to merge 2 commits into
Open
Conversation
leovalais
reviewed
Jul 8, 2026
flomonster
force-pushed
the
fam/fix-core-task-lock
branch
from
8774931 to
b631194
Compare
flomonster
force-pushed
the
fam/fix-core-task-lock
branch
from
a0e6571 to
cb123c6
Compare
leovalais
approved these changes
Jul 8, 2026
| // Store the compressed values using mset | ||
| if !compressed_items.is_empty() { | ||
| span!(Level::INFO, "Sending items to Redis") | ||
| .in_scope(|| self.mset::<_, _, ()>(&compressed_items)) |
Member
Author
There was a problem hiding this comment.
With @Castavo, we observed that the span duration was very short even if the query took way longer (even timed out). We see on the server side that the query takes ~1s. The issue is that we don't await the query response within the new span.
You think the previous version should work as I described? If yes, maybe there is something else going on here.
| ); | ||
| } | ||
| Ok(serialized) => { | ||
| let vk_client = vk_client.clone(); |
Contributor
There was a problem hiding this comment.
nit: not sure this clone is necessary (resolve if I'm worng)
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
flomonster
force-pushed
the
fam/fix-core-task-lock
branch
from
cb123c6 to
6264cac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debuging our issue with valkey I found out that we lock the valkey connection with the new core_task framework.
The idea is to use the pool instead.