rework on rc_service_*env api#1025
Merged
Merged
Conversation
the original api was made before we settled on reexport having the reexport list makes it simpler and cleaner to handle exported variabes one-at-a-time over as a block, and allow us to trivially enforce that only the reexported list are loaded into dependees
the service must be started, and the listed variables must be in the `reexport` list
avoids leaking reexports from parent openrc-run processes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original api was made before we settled on reexport
having the reexport list makes it simpler and cleaner to handle
exported variabes one-at-a-time over as a block, and allow us to
trivially enforce that only the reexported list are loaded into
dependees
also, it's more intuitive as it matches what libc's getenv/setenv looks like