fix out-of-bounds write stripping section comments in help_load_file#1641
Open
aizu-m wants to merge 1 commit into
Open
fix out-of-bounds write stripping section comments in help_load_file#1641aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated the
<!-- SECTION: -->parsing fromhelp_load_file()under ASan and fed it a comment with no text:Tracked it down from there.
ptrindexes intosectionafter thecupsCopyString(section, ...), but the trailing-strip loop guards the walk withptr > line.lineandsectionare separate stack buffers, so that test never boundsptrinsidesection.A section that is empty or all-whitespace up to
-->(e.g.<!-- SECTION:-->) putsptratsection[0]. The guard againstlinethen lets the loop decrement past the start ofsection, writing\0over the adjacent stack, and the followingisspace(*ptr & 255)reads out of bounds too.Bound the walk to
sectionand drop the stray trailing test. Valid section comments strip the same as before.