Skip to content

[LayoutEditor] Accurate Parameter Names & Default Color for New Sprites#1268

Merged
Delta-473 merged 2 commits into
OpenKH:masterfrom
TopazTK:master
Jul 25, 2026
Merged

[LayoutEditor] Accurate Parameter Names & Default Color for New Sprites#1268
Delta-473 merged 2 commits into
OpenKH:masterfrom
TopazTK:master

Conversation

@TopazTK

@TopazTK TopazTK commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Just some minor QoL stuff without me having to do too much.
Without these changes the tool is borderline unusable.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f629791-7898-4eae-974a-85ea8b5994c6

📥 Commits

Reviewing files that changed from the base of the PR and between 304ddf7 and d153db0.

📒 Files selected for processing (2)
  • OpenKh.Tools.LayoutEditor/AppSequenceEditor.cs
  • OpenKh.Tools.LayoutEditor/Dialogs/SpriteEditDialog.cs

📝 Walkthrough

Walkthrough

The layout editor now assigns default corner colors to newly added sprites and uses generic parameter labels for child animation property inputs. Existing field assignments, sprite editing, preview rendering, and size suggestions remain unchanged.

Changes

Layout editor updates

Layer / File(s) Summary
Initialize new sprite colors
OpenKh.Tools.LayoutEditor/Dialogs/SpriteEditDialog.cs
New sprites receive 0x80808080 for all four corner colors before being wrapped in a SpriteModel; existing editing and preview behavior is preserved.
Rename animation input labels
OpenKh.Tools.LayoutEditor/AppSequenceEditor.cs
Child animation inputs use ParamX, ParamY, ParamSize, ParamCr, and ParamEx while assigning values to the same animation group fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: delta-473

Poem

A rabbit hops through sprites bright,
Four corners shaded soft and light.
Params hop into their place,
Labels tidy up the space.
Wiggle, bounce, and review with grace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: accurate parameter names and default colors for new sprites.
Description check ✅ Passed The description is related to the layout editor usability improvements made in this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TopazTK

TopazTK commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f629791-7898-4eae-974a-85ea8b5994c6

📥 Commits
Reviewing files that changed from the base of the PR and between 304ddf7 and d153db0.

📒 Files selected for processing (2)

  • OpenKh.Tools.LayoutEditor/AppSequenceEditor.cs
  • OpenKh.Tools.LayoutEditor/Dialogs/SpriteEditDialog.cs

📝 Walkthrough

Walkthrough

The layout editor now assigns default corner colors to newly added sprites and uses generic parameter labels for child animation property inputs. Existing field assignments, sprite editing, preview rendering, and size suggestions remain unchanged.

Changes

Layout editor updates

Layer / File(s) Summary
Initialize new sprite colors
OpenKh.Tools.LayoutEditor/Dialogs/SpriteEditDialog.cs New sprites receive 0x80808080 for all four corner colors before being wrapped in a SpriteModel; existing editing and preview behavior is preserved.
Rename animation input labels
OpenKh.Tools.LayoutEditor/AppSequenceEditor.cs Child animation inputs use ParamX, ParamY, ParamSize, ParamCr, and ParamEx while assigning values to the same animation group fields.
Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: delta-473

Poem

A rabbit hops through sprites bright,
Four corners shaded soft and light.
Params hop into their place,
Labels tidy up the space.
Wiggle, bounce, and review with grace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: accurate parameter names and default colors for new sprites.
Description check ✅ Passed The description is related to the layout editor usability improvements made in this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nobody cares.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

@TopazTK Fair. The non-actionable walkthrough and extras were noise here; I’ll keep future output focused on actionable review findings.

🐇💭

@Delta-473 Delta-473 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Delta-473
Delta-473 merged commit 1a66e37 into OpenKH:master Jul 25, 2026
4 checks passed
@TopazTK

TopazTK commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

ty <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants