Skip to content

Declare never-null local variables as primitives (CodeQL java/non-null-boxed-variable) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vharseko merged 3 commits into from
Jul 16, 2026
Merged

Declare never-null local variables as primitives (CodeQL java/non-null-boxed-variable) #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8c29d
Declare never-null local variables as primitives (CodeQL java/non-nul…
vharseko Jul 8, 2026
6c13b49
Merge branch 'master' into features/codeql-non-null-boxed
vharseko Jul 9, 2026
01188d6
Merge branch 'master' into features/codeql-non-null-boxed
vharseko Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions commons/audit/core/src/main/java/org/forgerock/audit/util/DateUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@ public DateTime parseIfDate(final String timestamp) {
public static int getDateDifferenceInDays(final Date start, final Date end, final Boolean includeDay) {
Integer result = null;
if (start != null && end != null) {
final Long l = 86400000L;
final Long r = (end.getTime() - start.getTime()) / l;
result = r.intValue();
final long l = 86400000L;
final long r = (end.getTime() - start.getTime()) / l;
result = (int) r;
if (includeDay) {
result++;
}
Expand Down
7 changes: 4 additions & 3 deletions commons/audit/core/src/main/java/org/forgerock/audit/util/JsonValueUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* information: "Portions copyright [year] [name of copyright owner]".
*
* Copyright 2015-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

package org.forgerock.audit.util;
Expand Down Expand Up @@ -479,9 +480,9 @@ private int compareValues(final Object v1, final Object v2) {
final String s2 = (String) v2;
return s1.compareToIgnoreCase(s2);
} else if (v1 instanceof Number && v2 instanceof Number) {
final Double n1 = ((Number) v1).doubleValue();
final Double n2 = ((Number) v2).doubleValue();
return n1.compareTo(n2);
final double n1 = ((Number) v1).doubleValue();
final double n2 = ((Number) v2).doubleValue();
return Double.compare(n1, n2);
} else if (v1 instanceof Boolean && v2 instanceof Boolean) {
final Boolean b1 = (Boolean) v1;
final Boolean b2 = (Boolean) v2;
Expand Down
6 changes: 3 additions & 3 deletions commons/rest/json-resource/src/main/java/org/forgerock/json/resource/MemoryBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,9 @@ private static int compareValues(final Object v1, final Object v2) {
final String s2 = (String) v2;
return s1.compareToIgnoreCase(s2);
} else if (v1 instanceof Number && v2 instanceof Number) {
final Double n1 = ((Number) v1).doubleValue();
final Double n2 = ((Number) v2).doubleValue();
return n1.compareTo(n2);
final double n1 = ((Number) v1).doubleValue();
final double n2 = ((Number) v2).doubleValue();
return Double.compare(n1, n2);
} else if (v1 instanceof Boolean && v2 instanceof Boolean) {
final Boolean b1 = (Boolean) v1;
final Boolean b2 = (Boolean) v2;
Expand Down
4 changes: 2 additions & 2 deletions ...ugin/src/main/java/com/savage7/maven/plugin/dependency/InstallExternalDependencyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**

Check warning on line 1 in maven-external-dependency-plugin/maven-external-dependency-plugin/src/main/java/com/savage7/maven/plugin/dependency/InstallExternalDependencyMojo.java

View workflow job for this annotation

GitHub Actions / build-maven (macos-latest, 26) 

documentation comment is not attached to any declaration

Check warning on line 1 in maven-external-dependency-plugin/maven-external-dependency-plugin/src/main/java/com/savage7/maven/plugin/dependency/InstallExternalDependencyMojo.java

View workflow job for this annotation

GitHub Actions / build-maven (ubuntu-latest, 25) 

documentation comment is not attached to any declaration

Check warning on line 1 in maven-external-dependency-plugin/maven-external-dependency-plugin/src/main/java/com/savage7/maven/plugin/dependency/InstallExternalDependencyMojo.java

View workflow job for this annotation

GitHub Actions / build-maven (ubuntu-latest, 26) 

documentation comment is not attached to any declaration
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with this
* work for additional information regarding copyright ownership. The ASF
Expand Down Expand Up @@ -92,7 +92,7 @@
super.md5Digester = this.md5Digester;
super.sha1Digester = this.sha1Digester;

Boolean cachedCreateChecksums = this.createChecksum;
boolean cachedCreateChecksums = this.createChecksum;

getLog()
.info(
Expand All @@ -112,7 +112,7 @@

// determine if the artifact is already installed in the local
// Maven repository
Boolean artifactAlreadyInstalled = getLocalRepoFile(artifact)
boolean artifactAlreadyInstalled = getLocalRepoFile(artifact)
.exists();

// only proceed with this artifact if it is not already
Expand Down
2 changes: 1 addition & 1 deletion persistit/core/src/main/java/com/persistit/util/ThreadSequencer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ public static void appendHistoryElement(final StringBuilder sb, int location) {
public static String describeHistory(final int[] history) {
final StringBuilder sb = new StringBuilder();
if (history != null) {
for (final Integer location : history) {
for (final int location : history) {
if (sb.length() > 0) {
sb.append(',');
}
Expand Down
Loading