Skip to content

Enable doclint all,-missing with failOnWarnings; bump javadoc plugin to 3.12.0#99

Merged
vharseko merged 1 commit into
OpenIdentityPlatform:masterfrom
vharseko:doclint-all-missing-failonwarnings
Jul 16, 2026
Merged

Enable doclint all,-missing with failOnWarnings; bump javadoc plugin to 3.12.0#99
vharseko merged 1 commit into
OpenIdentityPlatform:masterfrom
vharseko:doclint-all-missing-failonwarnings

Conversation

@vharseko

Copy link
Copy Markdown
Member

Replaces the repo-wide <doclint>none</doclint> with a single inherited <doclint>all,-missing</doclint> property (referenced as ${doclint}), enables <failOnWarnings>true</failOnWarnings>, and bumps maven-javadoc-plugin 3.11.2 → 3.12.0.

POM changes

  • Root pom.xml: new <doclint>all,-missing</doclint> property; plugin config uses <doclint>${doclint}</doclint> + <failOnWarnings>true</failOnWarnings>; version 3.12.0 pinned once in root <pluginManagement>.
  • OpenICF-java-framework/pom.xml: dropped two stale 3.10.1 javadoc pins (build pluginManagement + <reporting>) that were overriding the bump for the whole framework tree.
  • testbundlev1 / testbundlev2: removed <skip>true</skip> on javadoc so javadoc now runs for every module (24 javadoc jars produced).

Doclint fixes (docs-only)

Fixed every doclint error and warning across all modules — real @param/@return/@throws descriptions, self-closing <p/><p>, <tt><code>, class-level {@inheritDoc} misuse, unknown/malformed tags, bogus @throws, and broken {@link}/@see references. No code semantics, signatures, or annotations were touched.

Verification

mvn clean package (the CI verify javadoc path — javadoc:jar with failOnWarnings=true) builds green with 0 errors / 0 warnings and all 24 javadoc jars produced on JDK 11, 17, 21, and 26.

Note: -Xdoclint's -missing group differs by JDK — on JDK 11 empty @param/@return tags fall under syntax, not missing, so they are fixed with real descriptions rather than suppressed.

…to 3.12.0

Replace the repo-wide <doclint>none</doclint> with a single inherited
<doclint>all,-missing</doclint> property referenced as ${doclint}, enable
<failOnWarnings>true</failOnWarnings>, and pin maven-javadoc-plugin 3.12.0
once in root pluginManagement (dropping the stale 3.10.1 pins in
OpenICF-java-framework). Remove the javadoc <skip> in testbundlev1/v2 so
javadoc runs everywhere.

Fix all resulting doclint errors and warnings across every module on both
JDK 11 and JDK 26 (docs-only changes): real @param/@return/@throws
descriptions, self-closing <p/> -> <p>, <tt> -> <code>, class-level
{@inheritdoc} misuse, unknown/malformed tags, bogus @throws, and broken
{@link}/@see references.
@vharseko
vharseko requested a review from maximthomas July 16, 2026 08:26
@vharseko vharseko added documentation README, docs, license headers dependencies Pull requests that update a dependency file ci CI, build & workflow changes java Pull requests that update java code labels Jul 16, 2026
@vharseko
vharseko merged commit f3f8ea2 into OpenIdentityPlatform:master Jul 16, 2026
68 of 71 checks passed
@vharseko
vharseko deleted the doclint-all-missing-failonwarnings branch July 16, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI, build & workflow changes dependencies Pull requests that update a dependency file documentation README, docs, license headers java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants