fix(audio-response): make repeated operations reliable - #144
Open
TobiasRoeddiger wants to merge 2 commits into
Open
fix(audio-response): make repeated operations reliable#144TobiasRoeddiger wants to merge 2 commits into
TobiasRoeddiger wants to merge 2 commits into
Conversation
|
Visit the preview URL for this PR (updated for commit 845face): https://open-earable-lib-web-example--pr144-codex-fix-ble-subs-69adpoxg.web.app (expires Tue, 25 Aug 2026 07:27:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operation already in progressstatus stream closedexceptionRoot causes
A disconnected stream can finish closing after the app has already reconnected and installed a new controller for the same characteristic. The old
onCancelcallback checked only whether the key existed, so it removed the new controller and disabled its notifications.Two related failure paths made this more visible during rapid Seal Check repetition:
Validation
flutter analyzeflutter test(11/11)Companion firmware fix: OpenEarable/open-earable-2#257