Keep last seen sensor available after first value#65
Open
LordMike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This follows up on the concern raised in #31 (comment).
The
last_seensensor represents historical Bluetooth observation data, not the current live state of the display. If the device disappears for a while, the last-seen timestamp is still meaningful; making the entity unavailable effectively turns "last seen at X" into "unknown" at exactly the time the timestamp is most useful.Other entities like temperature, RSSI, battery, button events, and touch events are live advertisement-derived state, so tying them to device availability makes sense.
last_seenis different: once it has observed a timestamp, it should remain available and keep reporting that timestamp.What Changed
last_seensensor availability behavior.last_seennow caches the first observed timestamp.Validation
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=/mnt/n/Personal/opendisplay-work/Home_Assistant_Integration /home/mike/.venvs/hass-dev/bin/python -m pytest -q tests/test_last_seen.py -p no:cacheprovider4 passed