-
Notifications
You must be signed in to change notification settings - Fork 7
build(config): Use dynamic port mapping for docker-compose #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,15 @@ | ||
| node_modules/ | ||
| src/stories/ | ||
| .storybook/ | ||
| dist/ | ||
| .idea/ | ||
| dist/ | ||
| .env | ||
| .DS_Store | ||
| CLAUDE.md | ||
|
|
||
| # Local override files | ||
| docker-compose.override.yml | ||
|
|
||
| # Added by code-review-graph | ||
| .code-review-graph/ | ||
| .claude/ | ||
| .claude/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| version: '3' | ||
|
|
||
| services: | ||
| web: | ||
| image: openconceptlab/oclweb3:${TAG-latest} | ||
|
|
@@ -9,7 +7,7 @@ services: | |
| NODE_ENV: production | ||
| PRIVATE_PACKAGES_GIT: | ||
| ports: | ||
| - "4002:4002" | ||
| - "${WEB_PORT-4002}:4002" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When developers use the README’s SSO command ( Useful? React with 👍 / 👎. |
||
| restart: on-failure | ||
| environment: | ||
| - API_URL=${API_URL-http://127.0.0.1:8000} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a clean checkout, this ignore entry plus the rename to
docker-compose.override.yml.bakmeansdocker-compose up -dno longer sees the dev override that used to settarget: build, bind-mount the source, and expose hot-reload/storybook ports; the README still documents that command as “Run Dev”. Docker’s Compose docs say defaultupreads the override file automatically (https://docs.docker.com/compose/how-tos/multiple-compose-files/merge/), so please either keep a committed dev compose file with an explicit README command or add setup docs to copy the.baktemplate.Useful? React with 👍 / 👎.