Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
node_modules/
src/stories/
.storybook/
dist/
.idea/
dist/
.env
.DS_Store
CLAUDE.md

# Local override files
docker-compose.override.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore an automatic dev compose path

For a clean checkout, this ignore entry plus the rename to docker-compose.override.yml.bak means docker-compose up -d no longer sees the dev override that used to set target: build, bind-mount the source, and expose hot-reload/storybook ports; the README still documents that command as “Run Dev”. Docker’s Compose docs say default up reads the override file automatically (https://docs.docker.com/compose/how-tos/multiple-compose-files/merge/), so please either keep a committed dev compose file with an explicit README command or add setup docs to copy the .bak template.

Useful? React with 👍 / 👎.


# Added by code-review-graph
.code-review-graph/
.claude/
.claude/
File renamed without changes.
4 changes: 1 addition & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: '3'

services:
web:
image: openconceptlab/oclweb3:${TAG-latest}
Expand All @@ -9,7 +7,7 @@ services:
NODE_ENV: production
PRIVATE_PACKAGES_GIT:
ports:
- "4002:4002"
- "${WEB_PORT-4002}:4002"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Propagate WEB_PORT through SSO compose

When developers use the README’s SSO command (docker-compose -f docker-compose.yml -f docker-compose.sso.yml up -d) and set WEB_PORT to avoid a local 4002 conflict, this new dynamic mapping is merged with the SSO file’s still-hardcoded 4002:4002 and LOGIN_REDIRECT_URL=http://localhost:4002, so the SSO path still binds and redirects to 4002. Docker’s Compose docs describe multiple -f files as combined in order with ports added/merged (https://docs.docker.com/compose/how-tos/multiple-compose-files/merge/), so the SSO compose file needs the same variable or an updated command.

Useful? React with 👍 / 👎.

restart: on-failure
environment:
- API_URL=${API_URL-http://127.0.0.1:8000}
Expand Down