fix(anycable): prevent gRPC keepalive too_many_pings GoAway - #3271
Merged
Conversation
AnyCable's default server min_recv_ping_interval_without_data_ms (10_000ms) matches anycable-go's hardcoded 10s client keepalive exactly. Jitter causes pings to arrive under the threshold, accumulating strikes and emitting GoAway ENHANCE_YOUR_CALM that tears down active RPCs (closes #3240). Halve the server minimum to 5_000ms for jitter tolerance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3271 +/- ##
==========================================
- Coverage 78.38% 78.35% -0.03%
==========================================
Files 676 677 +1
Lines 55634 55636 +2
Branches 728 728
==========================================
- Hits 43606 43592 -14
- Misses 11950 11966 +16
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
commented
Apr 24, 2026
| config.rpc_server_args = { | ||
| "grpc.keepalive_permit_without_calls" => 1, | ||
| "grpc.http2.min_recv_ping_interval_without_data_ms" => 5_000, | ||
| "grpc.http2.min_ping_interval_without_data_ms" => 5_000, |
Member
Author
There was a problem hiding this comment.
Setting both of these to 60_000 allowed me to reproduce the issue. At least I could see the ENHANCE_YOUR_CALM message.
ryanmelt
approved these changes
Apr 24, 2026
Member
Author
|
Also made upstream fix in anycable-rb: anycable/anycable-rb#6 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnyCable's default server min_recv_ping_interval_without_data_ms (10_000ms) matches anycable-go's hardcoded 10s client keepalive exactly. Jitter causes pings to arrive under the threshold, accumulating strikes and emitting GoAway ENHANCE_YOUR_CALM that tears down active RPCs (closes #3240). Halve the server minimum to 5_000ms for jitter tolerance.