Skip to content

[major] registry compliance - #1012

Open
millerds wants to merge 13 commits into
masterfrom
user/millerds/registry-compliance
Open

[major] registry compliance#1012
millerds wants to merge 13 commits into
masterfrom
user/millerds/registry-compliance

Conversation

@millerds

@millerds millerds commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Change Description:
Update .npmrc to use a compliant registry feed
Also include some package and tsconfig updates.

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)
    No.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)
    No.

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct

Validation/testing performed:
Ran automated tests

@millerds
millerds marked this pull request as ready for review July 29, 2026 19:30
@millerds
millerds requested a review from a team as a code owner July 29, 2026 19:30
@millerds
millerds requested a review from Copilot July 29, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo to use a compliant npm registry feed and aligns TypeScript/ESLint tooling across packages to work with newer Node/TypeScript settings.

Changes:

  • Point npm installs at an Azure Artifacts registry via .npmrc and document auth setup.
  • Update TypeScript compiler settings (Node16 module resolution, ES2020 target) and standardize rootDir in package tsconfigs.
  • Refresh dependency/tooling versions (notably ESLint 10, TypeScript 5.x, adm-zip 0.6) and simplify some ESLint configs.

Reviewed changes

Copilot reviewed 52 out of 54 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tsconfig.json Switch root TS config to Node16 module resolution and ES2020 target.
README.md Add npm registry authentication instructions.
.npmrc Change default npm registry to Azure Artifacts and enable always-auth.
.azure-devops/full-pipeline.yml Switch Node selection task to UseNode@1 for Node 24.x.
package.json Update engine ranges and dev tooling deps; adjust npm overrides for eslint peer alignment.
packages/office-addin-usage-data/tsconfig.json Set rootDir to src.
packages/office-addin-usage-data/package.json Tooling dependency tweaks (ESLint/TS-related).
packages/office-addin-test-server/tsconfig.json Set rootDir to src.
packages/office-addin-test-server/package.json Remove per-package TypeScript devDependency.
packages/office-addin-test-helpers/tsconfig.json Add rootDir and rely on extended target.
packages/office-addin-test-helpers/package.json Remove per-package TypeScript devDependency.
packages/office-addin-sso/tsconfig.json Set rootDir to src.
packages/office-addin-sso/package.json Remove per-package TypeScript devDependency.
packages/office-addin-project/tsconfig.json Set rootDir to src.
packages/office-addin-project/test/package.json Remove per-package TypeScript devDependency.
packages/office-addin-project/src/convert.ts Update zip backup error handling around writeZipPromise.
packages/office-addin-project/package.json Upgrade adm-zip and remove @types/adm-zip; remove per-package TypeScript devDependency.
packages/office-addin-node-debugger/tsconfig.json Set rootDir to src.
packages/office-addin-node-debugger/package.json Remove SDL ESLint plugin and per-package TypeScript devDependency.
packages/office-addin-node-debugger/eslint.config.mjs Remove SDL config and update parser options formatting.
packages/office-addin-mock/tsconfig.json Set rootDir to src.
packages/office-addin-mock/package.json Remove per-package TypeScript devDependency.
packages/office-addin-manifest/tsconfig.json Override module settings back to CJS/Node; set rootDir.
packages/office-addin-manifest/src/export.ts Update zip save error handling around writeZipPromise.
packages/office-addin-manifest/package.json Upgrade adm-zip to 0.6.0 and remove @types/adm-zip; remove per-package TypeScript devDependency.
packages/office-addin-lint/tsconfig.json Set rootDir to src.
packages/office-addin-lint/package.json Bump ESLint dependency to ^10.0.0 and remove per-package TypeScript devDependency.
packages/office-addin-dev-settings/tsconfig.json Set rootDir to src.
packages/office-addin-dev-settings/package.json Upgrade adm-zip; remove SDL ESLint plugin and @types/adm-zip; remove per-package TypeScript devDependency.
packages/office-addin-dev-settings/eslint.config.mjs Remove SDL config and update parser options formatting.
packages/office-addin-dev-certs/tsconfig.json Set rootDir to src.
packages/office-addin-dev-certs/package.json Remove per-package TypeScript devDependency.
packages/office-addin-debugging/tsconfig.json Set rootDir to src.
packages/office-addin-debugging/package.json Upgrade adm-zip; remove SDL ESLint plugin and @types/adm-zip; remove per-package TypeScript devDependency.
packages/office-addin-debugging/eslint.config.mjs Remove SDL config and update parser options formatting.
packages/office-addin-cli/tsconfig.json Set rootDir to src.
packages/office-addin-cli/package.json Tooling dependency tweaks (ESLint/TS-related).
packages/office-addin-cache/package.json Remove per-package TypeScript devDependency.
packages/eslint-plugin-office-addins/tsconfig.json Set rootDir to src.
packages/eslint-plugin-office-addins/package.json Expand ESLint peer range; add TypeScript peer; bump typescript-eslint packages.
packages/eslint-plugin-office-addins/jest.config.js Add explicit ts-jest transform overrides for TS compilation settings.
packages/eslint-plugin-excel-custom-functions/tsconfig.build.tsbuildinfo Add TS build info artifact file.
packages/eslint-plugin-excel-custom-functions/tests/rules/no-office-write-calls.test.ts Update RuleTester config to languageOptions.parserOptions.
packages/eslint-plugin-excel-custom-functions/tests/rules/no-office-read-calls.test.ts Update RuleTester config to languageOptions.parserOptions.
packages/eslint-plugin-excel-custom-functions/src/rules/no-office-write-calls.ts Remove unused type import; simplify parser services typing; adjust rule meta docs.
packages/eslint-plugin-excel-custom-functions/src/rules/no-office-read-calls.ts Remove unused type import; simplify parser services typing; adjust rule meta docs.
packages/eslint-plugin-excel-custom-functions/package.json Refresh dependencies/peers for ESLint + typescript-eslint v8 and TS 5.
packages/eslint-config-office-addins/tsconfig.json Set rootDir to src.
packages/eslint-config-office-addins/package.json Bump ESLint to ^10.0.0 and remove per-package TypeScript devDependency.
packages/custom-functions-metadata/tsconfig.json Set rootDir to src.
packages/custom-functions-metadata/package.json Adjust TypeScript devDependency range to ~4.9.5.
packages/custom-functions-metadata-plugin/tsconfig.json Set rootDir to src.
packages/custom-functions-metadata-plugin/package.json Remove per-package TypeScript devDependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/eslint-plugin-excel-custom-functions/tsconfig.build.tsbuildinfo Outdated
Comment thread README.md
Comment thread packages/office-addin-dev-settings/eslint.config.mjs
Comment thread packages/office-addin-project/src/convert.ts
Comment thread packages/office-addin-manifest/src/export.ts
Comment thread packages/office-addin-node-debugger/eslint.config.mjs
Comment thread packages/office-addin-debugging/eslint.config.mjs
@millerds millerds changed the title [patch] registry compliance [major] registry compliance Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants