Replace thin examples with full instructional R vignette ports#124
Closed
OVVO-Financial wants to merge 17 commits into
Closed
Replace thin examples with full instructional R vignette ports#124OVVO-Financial wants to merge 17 commits into
OVVO-Financial wants to merge 17 commits into
Conversation
Repair the failures in the full R vignette port suite: - 01_overview: replace the thin delegate shim with a full nine-section instructional port of NNSvignette_01_Overview.Rmd, including figures for the partial-moment decomposition, mode estimation, copula surfaces, nonlinear regression, ARMA forecasting, and Monte Carlo replicates. - 04_normalization: pass a list instead of a generator to np.column_stack, which numpy rejects at runtime. - 05_sampling: replace the assertion-style smoke script with a full section-by-section port of NNSvignette_05_Sampling.Rmd with CDF, inverse-CDF, Monte Carlo, and dependence-transfer figures. - 06_comparing_distributions: replace the smoke script with a full port of NNSvignette_06_Comparing_Distributions.Rmd, reconstructing the R ANOVA plot side effects from the returned statistics and adding superiority, dominance, and SD-cluster figures. - 07_clustering_and_regression: restore the file body that was committed truncated after its module docstring, porting every R section including partition orders, X-only partitioning, multivariate regression over the full grid, dimension reduction, stacking, smoothing, and imputation. - 08_classification and _vignette_support: stop rounding non-numeric arrays in the compact result renderer, and display rhs.partitions now that the multivariate result exposes it (correcting the stale gap note). - PARITY.md: update the 07/08 ledger entries to match the ports. - Lint compliance for ruff check across the examples tree, with a scoped E402 ignore for the sys.path bootstrap in instructional scripts, and ignore the generated figure output directory. All nine canonical scripts pass tests/docs/test_vignette_examples.py in fast mode and run clean in full mode; ruff and mypy pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014q6V4fJ7zz6KLAgu3ddhDp
Owner
Author
|
Superseded by #129, which carries this branch's full vignette ports plus the fixes that took CI green (identical head commit). Closing to avoid a duplicate merge. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the abbreviated numbered Python examples with section-by-section instructional ports of the canonical R NNS vignettes.
Acceptance standard
What changed
iris,mtcars, andAirPassengersdatasets.PARITY.md, a per-vignette section and API-gap ledger.manifest.ymlinto a machine-readable acceptance contract.Runtime behavior
Normal execution runs the full R-equivalent parameter grids and repetitions.
NNS_VIGNETTE_FAST=1reduces expensive repetitions and candidate grids for CI without removing sections or changing the instructional sequence.Known explicit gaps
The scripts identify gaps at the relevant sections, including R Voronoi rendering,
rhs.partitions, interactiverglviews, separateseasonal.plotoutput, and stochastic bit-for-bit RNG differences. No missing API is silently replaced with an unrelated demonstration.Validation
Draft until the Python 3.11–3.14 matrix, figure-generation checks, linting, typing, and distribution builds pass.