Support UDA for WINJMULT item 2 - #7287
Draft
vkip wants to merge 2 commits into
Draft
Conversation
vkip
added
the
manual:enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for using UDA/UDQ expressions as the WINJMULT “fracture pressure” (item 2), enabling injection multiplier behavior to be driven by SummaryState-updated UDQ values.
Changes:
- Evaluate
WINJMULTfracture pressure viaUDA::eval_well_uda(...)usingSummaryStateinWellInterfaceGeneric::getInjMult(). - Thread
SummaryStatethroughgetInjMult()call sites in both standard and multisegment wells. - Add a focused unit test plus new regression/restart/parallel test registrations for WINJMULT+UDQ cases.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_wellmodel.cpp | Adds a unit test verifying UDQ-driven fracture pressure affects WINJMULT as expected. |
| restartTests.cmake | Registers a restarted-simulation comparison test for WINJMULT_UDQ_STDW. |
| regressionTests.cmake | Adds WINJMULT_UDQ_* cases to the WINJMULT regression set. |
| parallelTests.cmake | Registers a parallel simulation comparison test for WINJMULT_UDQ_MSW. |
| opm/simulators/wells/WellInterfaceGeneric.hpp | Updates getInjMult() API to accept SummaryState. |
| opm/simulators/wells/WellInterfaceGeneric.cpp | Implements UDA evaluation for fracture pressure in getInjMult(). |
| opm/simulators/wells/StandardWell_impl.hpp | Passes summaryState() into getInjMult() from the standard-well path. |
| opm/simulators/wells/MultisegmentWell_impl.hpp | Passes summaryState() into getInjMult() from the multisegment-well path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+285
to
+289
| const auto frac_press = static_cast<Scalar>( | ||
| UDA::eval_well_uda(injmult.fracture_pressure, | ||
| this->name(), | ||
| summary_state, | ||
| summary_state.get_udq_undefined())); |
Member
Author
|
jenkins build this opm-common=5273 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OPM/opm-common#5273