flow: let problems append a section to the simulation trailer - #7253
Merged
Conversation
hnil
added
the
manual:enhancement
akva2
reviewed
Aug 5, 2026
| const double deck_read_time, | ||
| const SimulatorReport& report); | ||
| const SimulatorReport& report, | ||
| std::string_view extra_summary = {}); |
printFlowTrailer gains a defaulted extra_summary argument, and FlowMain fills it from the new FlowProblem::extraTrailerSummary() (default: empty; derived problems shadow it -- e.g. geomechanics timing summaries). Generic code carries no module-specific names. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
Default dropped — there is only the one caller, and it always passes the summary. |
hnil
force-pushed
the
pr/trailer-summary-hook
branch
from
August 7, 2026 14:44
f0c10f2 to
239d3d8
Compare
Member
|
jenkins build this please |
bska
approved these changes
Aug 7, 2026
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me now and I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printFlowTrailergains a defaulted extra-summary argument, filled from a newFlowProblem::extraTrailerSummary()(default: empty). No output change for standard runs; opm-flowgeomechanics uses it for its timing summary.