Skip to content

Refactor headers#426

Merged
ospfranco merged 8 commits into
mainfrom
oscar/refactor-headers
Jul 5, 2026
Merged

Refactor headers#426
ospfranco merged 8 commits into
mainfrom
oscar/refactor-headers

Conversation

@ospfranco

Copy link
Copy Markdown
Contributor
  • Refactors header file endings to .hpp to reflect proper C++ code
  • Hides header from the app to hopefully prevent header clashes
  • Set C++ language standard to 23, seems to give a small perf boost

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the C++/Objective-C++ header layout (renaming internal headers to .hpp and updating includes), and adjusts the CocoaPods spec to change how headers and compilation settings are exported/compiled for iOS consumers.

Changes:

  • Renames multiple C++ headers from .h to .hpp and updates include sites accordingly.
  • Updates the CocoaPods podspec (notably public header handling and C++ language standard).
  • Re-enables a delayed performance test run in the example app.

Reviewed changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
op-sqlite.podspec Updates pod build configuration, source/exclude lists, and public header exposure.
example/src/App.tsx Re-enables a delayed performance test execution after app start.
example/ios/Podfile.lock Updates the example app’s pod lock checksum for op-sqlite.
cpp/utils.hpp Updates internal includes to .hpp variants.
cpp/utils.cpp Updates internal includes to .hpp variants (including bridge/threadpool).
cpp/SmartHostObject.hpp Adds new .hpp header for SmartHostObject.
cpp/SmartHostObject.cpp Updates include to use SmartHostObject.hpp.
cpp/PreparedStatementHostObject.hpp Updates threadpool include to .hpp.
cpp/PreparedStatementHostObject.cpp Updates includes to .hpp variants (host object + bridge).
cpp/OPThreadPool.hpp Adds new .hpp header for the thread pool interface.
cpp/OPThreadPool.cpp Updates include to use OPThreadPool.hpp.
cpp/OPSqlite.cpp Updates internal includes to .hpp variants (host objects, bridge, threadpool).
cpp/DumbHostObject.hpp Updates SmartHostObject include to .hpp.
cpp/DumbHostObject.cpp Updates includes to use .hpp variants.
cpp/DBHostObject.hpp Updates threadpool include to .hpp.
cpp/DBHostObject.cpp Updates includes to use .hpp variants (DB + prepared statement + bridge).
cpp/bridge.hpp Updates host object includes to .hpp variants.
cpp/bridge.cpp Updates includes to use .hpp variants (bridge + host objects).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread example/src/App.tsx
Comment thread op-sqlite.podspec Outdated
Comment thread op-sqlite.podspec
Comment thread op-sqlite.podspec Outdated
Comment thread op-sqlite.podspec Outdated
ospfranco and others added 6 commits July 5, 2026 15:43
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ospfranco ospfranco merged commit 690b587 into main Jul 5, 2026
10 checks passed
@ospfranco ospfranco deleted the oscar/refactor-headers branch July 5, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants