Refactor headers#426
Merged
Merged
Conversation
ospfranco
commented
Jul 5, 2026
Contributor
- Refactors header file endings to .hpp to reflect proper C++ code
- Hides header from the app to hopefully prevent header clashes
- Set C++ language standard to 23, seems to give a small perf boost
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the C++/Objective-C++ header layout (renaming internal headers to .hpp and updating includes), and adjusts the CocoaPods spec to change how headers and compilation settings are exported/compiled for iOS consumers.
Changes:
- Renames multiple C++ headers from
.hto.hppand updates include sites accordingly. - Updates the CocoaPods podspec (notably public header handling and C++ language standard).
- Re-enables a delayed performance test run in the example app.
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| op-sqlite.podspec | Updates pod build configuration, source/exclude lists, and public header exposure. |
| example/src/App.tsx | Re-enables a delayed performance test execution after app start. |
| example/ios/Podfile.lock | Updates the example app’s pod lock checksum for op-sqlite. |
| cpp/utils.hpp | Updates internal includes to .hpp variants. |
| cpp/utils.cpp | Updates internal includes to .hpp variants (including bridge/threadpool). |
| cpp/SmartHostObject.hpp | Adds new .hpp header for SmartHostObject. |
| cpp/SmartHostObject.cpp | Updates include to use SmartHostObject.hpp. |
| cpp/PreparedStatementHostObject.hpp | Updates threadpool include to .hpp. |
| cpp/PreparedStatementHostObject.cpp | Updates includes to .hpp variants (host object + bridge). |
| cpp/OPThreadPool.hpp | Adds new .hpp header for the thread pool interface. |
| cpp/OPThreadPool.cpp | Updates include to use OPThreadPool.hpp. |
| cpp/OPSqlite.cpp | Updates internal includes to .hpp variants (host objects, bridge, threadpool). |
| cpp/DumbHostObject.hpp | Updates SmartHostObject include to .hpp. |
| cpp/DumbHostObject.cpp | Updates includes to use .hpp variants. |
| cpp/DBHostObject.hpp | Updates threadpool include to .hpp. |
| cpp/DBHostObject.cpp | Updates includes to use .hpp variants (DB + prepared statement + bridge). |
| cpp/bridge.hpp | Updates host object includes to .hpp variants. |
| cpp/bridge.cpp | Updates includes to use .hpp variants (bridge + host objects). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.