feat(packages): variabilize the ingressClassName in the ingress objec… - #52
Merged
Merged
Conversation
…ts instead of having it hardcoded to nginx
Contributor
Author
|
Make sure the component' version bumps do not conflict with other PRs. |
rpignolet
approved these changes
Aug 18, 2026
mlahouar
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ts instead of having it hardcoded to nginx
Description
Replace the hardcoded value
nginxwith{{ .Context.platform.ingress.className }}defined in the default context for the key ingressClassName in the ingress objects of the components.Related Issue
Fixes #51
Type of Change
How to Test
Checklist