Implement API Keys.#2526
Merged
Merged
Conversation
Fixes #1884.
Collaborator
Author
|
@p-hoffmann : this PR is independent of #2523, but there is some overlap with base migrations and the JWT auth filter. I will merge this branch with the webapi-3.0 branch and then update this PR. |
Collaborator
Author
|
The merge went through with no conflicts, and from my glance, I can see your changes were applied. This should be ready for review. Note: while I made IT tests, i had to run them manually because for some reason the Embedded PG instance can not initilize on my local enviornment. I'm hoping the tests will run on the git action. |
Collaborator
Author
|
Looks like tests pass and merge was clean, so @p-hoffmann if you want to give a quick review, this can be merged when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1884.
This PR introduces API Keys by creating a new controller (for create/list/delete operations), a database table and repository (sec_api_key), and migration scripts to define the tables (in a migration script and in baseline).