Skip to content

add features for observation.value_as_number#328

Merged
ginberg merged 2 commits into
developfrom
325
Jun 24, 2026
Merged

add features for observation.value_as_number#328
ginberg merged 2 commits into
developfrom
325

Conversation

@ginberg

@ginberg ginberg commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

see #325

@AniekMarkus

Copy link
Copy Markdown

Thanks - this works!

@ginberg ginberg linked an issue Jun 19, 2026 that may be closed by this pull request
@ginberg ginberg requested a review from anthonysena June 19, 2026 13:09
@anthonysena

Copy link
Copy Markdown
Collaborator

Looks good @ginberg! Upon review, I had a small suggestion which is to rename inst/sql/sql_server/MeasurementValue.sql to inst/sql/sql_server/DomainValueAsNumber.sql since you've made this query more generic to go beyond the Measurement domain. I wouldn't worry about checking the inner workings of the query (i.e. some of the temp tables use #meas_). Let me know what you think otherwise this is ready to merge from my side.

@ginberg

ginberg commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@anthonysena thanks for reviewing! good idea to make the name more generic, I will make an update

@ginberg ginberg merged commit 2cd4aac into develop Jun 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-specified features for observation.value_as_number

3 participants