Skip to content

Removed TODO definition annotations, added synonyms to 'treatment' an…#200

Open
dillerm wants to merge 3 commits into
masterfrom
removeduplicatedefinitions
Open

Removed TODO definition annotations, added synonyms to 'treatment' an…#200
dillerm wants to merge 3 commits into
masterfrom
removeduplicatedefinitions

Conversation

@dillerm

@dillerm dillerm commented May 11, 2026

Copy link
Copy Markdown
Contributor

…d 'prophylactic treatment', and added COB import.

…d 'prophylactic treatment', and added COB import.
@dillerm dillerm requested a review from zhengj2007 May 11, 2026 15:21

@zhengj2007 zhengj2007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors were identified directly within the OGMS terms; however, several issues exist regarding imported terms.

  • Import term files: Currently, the XXX_terms.txt files (corresponding to XXX_import.owl under src/ontology/imports/) are empty. These must be populated with the relevant terms for each ontology prefix (e.g., bfo, cob, iao). For instance, cob_terms.txt should contain entries such as COB:0000035, COB:0000082 etc.
  • Deprecated OBI terms: There are two "planned process" terms in OGMS. The OBI one is deprecated and replaced with COB:0000035. All subclasses should be migrated under COB:0000035 (completely executed planned process) and removed imported OBI "planned process". OBI ‘organism’ should be replaced with the corresponding COB term as well.
  • APOLLO_SV terms: OGMS imports APOLLO_SV terms via IAO. We should create a dedicated apollo_sv.owl and apollo_sv_terms.txt to import these terms directly.

@hoganwr

hoganwr commented May 24, 2026 via email

Copy link
Copy Markdown
Collaborator

@dillerm

dillerm commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@zhengj2007

  • We do not use XXX_terms.txt files for imports because we use the custom import template.
  • I replaced the OBI terms 'organism' and 'planned process' with their respective COB terms. However, OBI:0000011 (planned process) is still appearing in our OBI import file despite not being declared as an import. I am open to suggestions on how to fix this, as I am stumped.
  • No action is needed here, per @hoganwr 's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants