kb-doctor: bootstrap flow — "finish my KB setup" installs the remaining plugins - #504
Merged
Conversation
…lugins Onboarding collapses to two commands (marketplace add + install kb-access); kb-doctor then installs the sibling ds-team plugins + hdx@hdx-ai-hub on request and walks the user through choosing the KB location interactively. USING.md quick start updated to match; manual per-plugin path kept.
zackarno
approved these changes
Aug 3, 2026
zackarno
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with independent verification — approving.
Verified:
- The referenced state surfaces are real and correctly named:
~/.claude/plugins/known_marketplaces.jsonholds marketplace keys, user-scope installs land inenabledPluginsin~/.claude/settings.json. Checked on a live machine that happens to be exactly the bootstrap target state (onlykb-accessat user scope, nohdx-ai-hubmarketplace) — the flow's preconditions are realistic, not hypothetical. - CLI claims check out:
claude plugin install --helpconfirms default--scopeisuserand a single<plugin>argument (no batch form) — the one-install-per-plugin loop is necessary, not a style choice. - "run checks 1–6 above" matches the existing skill's numbering exactly.
- Description budget: 469 chars (per-skill cap 1024), aggregate ~2.9k of 6144 — and the eager-surface growth passes the D94 test: trigger phrases are how a skill fires (coordination, not shape), and the observed failure is named in the PR body (the easy-to-forget
.kb-repos-dirline). CI green (lint-docs runs the assets gate + link check). - No overlap with #505's USING.md section (different regions; PR is MERGEABLE, blocked only on this review).
- One-home-per-fact holds: step 3 defers to kb-search's location-choosing flow instead of duplicating it.
One non-blocking suggestion, fine as a follow-up: step 4 leaves the actual clone to the next session start, so a user who runs bootstrap and immediately asks a KB question still has nothing on disk, and the final table shows checks 1–2 failing with "wait for restart" as the remedy. kb-doctor could instead run kb_sync.sh straight from the plugin cache once .kb-repos-dir is written (check 3 already documents hand-running it) — then "finish my KB setup" actually finishes it, clone included, and the verify table ends green. Your call whether that's worth a line in this PR or a later tweak.
…ring setup Per review: step 4 now hand-runs scripts/kb_sync.sh from the plugin cache once .kb-repos-dir is written, instead of deferring the clone to the next session start — the verify table ends green, clone included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-wide onboarding previously meant five copy-pasted lines (two marketplace adds, a per-plugin install loop, and the easy-to-forget
~/.claude/.kb-repos-dirline). This collapses it to two commands plus one sentence to Claude:then "finish my KB setup" in any session — the kb-doctor skill (which already audits plugin enablement) now also:
hdx-ai-hubmarketplace if missing,data-access,data-conventions,aa-methods,infra-ops,hdx@hdx-ai-hub) at user scope, oneclaude plugin installper plugin (the CLI takes no batch argument), confirming the list once since some users deliberately run a subset,docs/USING.mdquick start updated to match; the manual per-plugin path and the zero-command per-repo trust-prompt path are kept. No setup script introduced — the plugin remains the setup, with kb-doctor as the installer for the rest.