Conversation
Added a TODO comment for gradual implementation.
Added a TODO comment for gradual implementation.
🤖 ParseCore Bot — PR ReviewHi @Error44s! I checked this pull request automatically. Here is my verdict: ❌ Not ready yetSome checks did not pass. Please fix the points marked with ❌ below and I will re-check automatically on your next push or edit.
What to fix
🤖 I am not a human I re-run on every push and edit. Configure me in |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rmance classes with combo tracking
…ance, and ManiaScoreState
… to TaikoScoreState
… weighted calculations
…aiko, catch, and mania
…mize peak storage
|
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Summary
This draft pull request introduces gradual difficulty and performance calculation support for parsecore.
Gradual calculation is already implemented for osu!catch. Support for osu!, osu!taiko, and osu!mania is planned but has not been implemented yet and is currently represented by
TODOsections.The purpose of this draft PR is to track the implementation progress, review the shared API and structure early, and complete support for all game modes before marking the PR as ready for review.
Type of Change
Current Status
Gradual difficulty and performance calculation is currently available only for osu!catch.
The remaining game modes still contain incomplete sections marked with
TODO.Changes
CatchScoreStateCatchGradualDifficultyCatchGradualPerformancenext(),nth(), andlast()TODOmarkers for unfinished osu!, taiko, and mania implementationsImplemented: osu!catch
The catch implementation currently supports:
Remaining Work
osu!
osu!taiko
osu!mania
Shared Work
TODOsectionsTesting
The catch implementation still requires complete automated validation.
The existing test suite can be run with: